Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1092423003: [Effen] Reduce splashes when scrolling. (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Reduce splashes when scrolling. Pipe the remaining time for an animation all the way out to the AnimatedValue. Make splashes abortable, which causes them to continue to fade but no longer grow, by having them fade in 100ms or however long the animation was still going to go for, whichever is quickest. Make Scrollables support objects registering with them to be told when scrolling happens. Make UINode support subclasses being informed when _remove() was called. Hook all that together to make splashes go away when scrolling by having them register with any ancestor Scrollables such that when those scroll, all the splashes get aborted. Unregister when removed. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9b93cd7fb5101893cbeec17a2afcfba8544cd5e0

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix comments from eseidel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -8 lines) Patch
M sky/framework/animation/animated_value.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/framework/animation/generators.dart View 2 chunks +9 lines, -1 line 0 comments Download
M sky/framework/components/ink_splash.dart View 1 4 chunks +25 lines, -6 lines 0 comments Download
M sky/framework/components/ink_well.dart View 1 3 chunks +31 lines, -1 line 0 comments Download
M sky/framework/components/scrollable.dart View 1 2 chunks +35 lines, -0 lines 0 comments Download
M sky/framework/fn.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
https://codereview.chromium.org/1092423003/diff/1/sky/framework/components/ink_splash.dart File sky/framework/components/ink_splash.dart (right): https://codereview.chromium.org/1092423003/diff/1/sky/framework/components/ink_splash.dart#newcode70 sky/framework/components/ink_splash.dart:70: var s; What does s mean? https://codereview.chromium.org/1092423003/diff/1/sky/framework/components/ink_well.dart File sky/framework/components/ink_well.dart ...
5 years, 8 months ago (2015-04-20 22:45:04 UTC) #2
Hixie
https://codereview.chromium.org/1092423003/diff/1/sky/framework/components/ink_splash.dart File sky/framework/components/ink_splash.dart (right): https://codereview.chromium.org/1092423003/diff/1/sky/framework/components/ink_splash.dart#newcode70 sky/framework/components/ink_splash.dart:70: var s; On 2015/04/20 at 22:45:04, eseidel wrote: > ...
5 years, 8 months ago (2015-04-20 22:49:40 UTC) #3
eseidel
lgtm
5 years, 8 months ago (2015-04-20 22:51:19 UTC) #4
Hixie
5 years, 8 months ago (2015-04-20 22:51:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9b93cd7fb5101893cbeec17a2afcfba8544cd5e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698