Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1092403002: Stop closing batch prematurely (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@atdfopt3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : stop closing batches prematurely #

Patch Set 4 : tweaks #

Patch Set 5 : fix nvpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -16 lines) Patch
M src/gpu/GrInOrderDrawBuffer.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 3 4 12 chunks +49 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
joshualitt
ptal
5 years, 7 months ago (2015-04-27 15:27:08 UTC) #3
robertphillips
lgtm
5 years, 7 months ago (2015-04-27 15:58:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092403002/60001
5 years, 7 months ago (2015-04-27 17:36:08 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/db3ce12c810ead7b76faa784e7293197aca0d9f1
5 years, 7 months ago (2015-04-27 17:43:23 UTC) #7
joshualitt
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1109773003/ by joshualitt@google.com. ...
5 years, 7 months ago (2015-04-27 18:18:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092403002/60001
5 years, 7 months ago (2015-04-27 18:25:40 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/9e830ead85e544924344b01436c44cfb09fcf177
5 years, 7 months ago (2015-04-27 18:29:21 UTC) #11
joshualitt
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1105203002/ by joshualitt@google.com. ...
5 years, 7 months ago (2015-04-27 18:42:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092403002/80001
5 years, 7 months ago (2015-04-27 18:55:50 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 19:03:08 UTC) #16
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0dcb8e32dda93b098d19892a62a528dc6ae1017b

Powered by Google App Engine
This is Rietveld 408576698