tools/telemetry/telemetry/core/browser.py - Issue 1092393002: Telemetry: Quiescent power benchmarks for Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser.py

Issue 1092393002: Telemetry: Quiescent power benchmarks for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@safari-backend

Patch Set: Fix unit test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/browser.py

diff --git a/tools/telemetry/telemetry/core/browser.py b/tools/telemetry/telemetry/core/browser.py

index 59e984048b3150e19b0c561db927e310a6cf2392..9e471995efb84696c337ea8ace667d3a0f8293fc 100644

--- a/tools/telemetry/telemetry/core/browser.py

+++ b/tools/telemetry/telemetry/core/browser.py

@@ -205,11 +205,6 @@ class Browser(app.App):

result = self._GetStatsCommon(self._platform_backend.GetCpuStats)

del result['ProcessCount']

- # FIXME: Renderer process CPU times are impossible to compare correctly.

- # http://crbug.com/419786#c11

- if 'Renderer' in result:

- del result['Renderer']

# We want a single time value, not the sum for all processes.

cpu_timestamp = self._platform_backend.GetCpuTimestamp()

for process_type in result:

« no previous file with comments | « tools/perf/metrics/cpu.py ('k') | no next file » | no next file with comments »