Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/perf/metrics/cpu.py

Issue 1092393002: Telemetry: Quiescent power benchmarks for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@safari-backend
Patch Set: Fix missing idle_wakeups_renderer Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/cpu.py
diff --git a/tools/perf/metrics/cpu.py b/tools/perf/metrics/cpu.py
index 35c3403fd0df9527b25ff8d1c9b9dadc600a17c0..66424d4ae8dcf84fd5e3a92db437d7556258e90b 100644
--- a/tools/perf/metrics/cpu.py
+++ b/tools/perf/metrics/cpu.py
@@ -32,6 +32,12 @@ class CpuMetric(Metric):
def AddResults(self, tab, results, trace_name='cpu_utilization'):
assert self._stop_cpu, 'Must call Stop() first'
cpu_stats = _SubtractCpuStats(self._stop_cpu, self._start_cpu)
+
+ # FIXME: Renderer process CPU times are impossible to compare correctly.
+ # http://crbug.com/419786#c11
+ if 'Renderer' in cpu_stats:
+ del cpu_stats['Renderer']
+
# Add a result for each process type.
for process_type in cpu_stats:
trace_name_for_process = '%s_%s' % (trace_name, process_type.lower())

Powered by Google App Engine
This is Rietveld 408576698