tools/perf/measurements/energy.py - Issue 1092393002: Telemetry: Quiescent power benchmarks for Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/energy.py

Issue 1092393002: Telemetry: Quiescent power benchmarks for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@safari-backend

Patch Set: Fix missing idle_wakeups_renderer Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import time

	6

	7 from metrics import cpu

	8 from metrics import power

	9 from telemetry.page import page_test

	10

	11

	12 class Energy(page_test.PageTest):
	sullivan 2015/04/21 15:56:53 It's pretty confusing to have both "Power" and "En It's pretty confusing to have both "Power" and "Energy" measurements/benchmarks with no comments in either file about the reasoning for having both and the naming. Is it possible to move these new measurements and benchmarks into the power.py files so they're all in the same place? Andre 2015/04/22 00:46:54 Done, merged into power.py. Show quoted text On 2015/04/21 15:56:53, sullivan wrote: > It's pretty confusing to have both "Power" and "Energy" measurements/benchmarks > with no comments in either file about the reasoning for having both and the > naming. Is it possible to move these new measurements and benchmarks into the > power.py files so they're all in the same place? Done, merged into power.py.
	13 """Measures energy usage and idle wakeups after the page is loaded."""

	14

	15 # Amount of time to measure, in seconds.

	16 SAMPLE_TIME = 30

	17

	18 def ValidateAndMeasurePage(self, page, tab, results):

	19 metric = power.PowerMetric(tab.browser.platform)

	20 metric.Start(page, tab)

	21

	22 time.sleep(Energy.SAMPLE_TIME)

	23

	24 metric.Stop(page, tab)

	25 metric.AddResults(tab, results)

OLD	NEW

« no previous file with comments | « tools/perf/benchmarks/energy.py ('k') | tools/perf/metrics/cpu.py » ('j') | no next file with comments »