Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1092383003: Remove redundant test files for native app banner testing on android. (Closed)

Created:
5 years, 8 months ago by benwells
Modified:
5 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant test files for native app banner testing on android. There are similar test files that are used by non-android specific testing that can be used instead. BUG=457403 Committed: https://crrev.com/aa4471e8d1d5f728394458a31ff5f913702e612f Cr-Commit-Position: refs/heads/master@{#327149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/test/data/android/banners/native_app_manifest.json View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/android/banners/native_app_test.html View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/android/banners/native_app_test.png View Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 8 months ago (2015-04-27 09:56:38 UTC) #2
gone
lgtm
5 years, 8 months ago (2015-04-27 17:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092383003/1
5 years, 8 months ago (2015-04-27 21:47:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 21:53:16 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:55:15 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa4471e8d1d5f728394458a31ff5f913702e612f
Cr-Commit-Position: refs/heads/master@{#327149}

Powered by Google App Engine
This is Rietveld 408576698