Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: src/code-stubs.h

Issue 1092353002: [strong] Disallow implicit conversions for binary arithmetic operations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 5 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | src/ic/ic.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 424026f40b24b27390278541d7b35f341017548d..a6bd45f876b984d655ae5bc82a9f5ccfe25c4798 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1248,9 +1248,9 @@ class CallApiGetterStub : public PlatformCodeStub {
class BinaryOpICStub : public HydrogenCodeStub {
public:
- BinaryOpICStub(Isolate* isolate, Token::Value op)
+ BinaryOpICStub(Isolate* isolate, Token::Value op, LanguageMode language_mode)
: HydrogenCodeStub(isolate, UNINITIALIZED) {
- BinaryOpICState state(isolate, op);
+ BinaryOpICState state(isolate, op, language_mode);
set_sub_minor_key(state.GetExtraICState());
}
@@ -1331,8 +1331,9 @@ class BinaryOpICWithAllocationSiteStub final : public PlatformCodeStub {
class BinaryOpWithAllocationSiteStub final : public BinaryOpICStub {
public:
- BinaryOpWithAllocationSiteStub(Isolate* isolate, Token::Value op)
- : BinaryOpICStub(isolate, op) {}
+ BinaryOpWithAllocationSiteStub(Isolate* isolate, Token::Value op,
+ LanguageMode language_mode)
+ : BinaryOpICStub(isolate, op, language_mode) {}
BinaryOpWithAllocationSiteStub(Isolate* isolate, const BinaryOpICState& state)
: BinaryOpICStub(isolate, state) {}
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | src/ic/ic.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698