[strong] Disallow implicit conversions for binary arithmetic operations

src/compiler/js-operator.h

Index: src/compiler/js-operator.h
diff --git a/src/compiler/js-operator.h b/src/compiler/js-operator.h
index 401f1f0b30e3e4629529c3d30de65d28c3b1c003..6afcc3036fd14eb4fb9f968e96bf883e96c6076e 100644
--- a/src/compiler/js-operator.h
+++ b/src/compiler/js-operator.h
@@ -217,23 +217,23 @@ class JSOperatorBuilder final : public ZoneObject {
   const Operator* NotEqual();
   const Operator* StrictEqual();
   const Operator* StrictNotEqual();
-  const Operator* LessThan();
-  const Operator* GreaterThan();
-  const Operator* LessThanOrEqual();
-  const Operator* GreaterThanOrEqual();
-  const Operator* BitwiseOr();
-  const Operator* BitwiseXor();
-  const Operator* BitwiseAnd();
-  const Operator* ShiftLeft();
-  const Operator* ShiftRight();
-  const Operator* ShiftRightLogical();
-  const Operator* Add();
-  const Operator* Subtract();
-  const Operator* Multiply();
-  const Operator* Divide();
-  const Operator* Modulus();
-
-  const Operator* UnaryNot();
+  const Operator* LessThan(LanguageMode language_mode);
+  const Operator* GreaterThan(LanguageMode language_mode);
+  const Operator* LessThanOrEqual(LanguageMode language_mode);
+  const Operator* GreaterThanOrEqual(LanguageMode language_mode);
+  const Operator* BitwiseOr(LanguageMode language_mode);
+  const Operator* BitwiseXor(LanguageMode language_mode);
+  const Operator* BitwiseAnd(LanguageMode language_mode);
+  const Operator* ShiftLeft(LanguageMode language_mode);
+  const Operator* ShiftRight(LanguageMode language_mode);
+  const Operator* ShiftRightLogical(LanguageMode language_mode);
+  const Operator* Add(LanguageMode language_mode);
+  const Operator* Subtract(LanguageMode language_mode);
+  const Operator* Multiply(LanguageMode language_mode);
+  const Operator* Divide(LanguageMode language_mode);
+  const Operator* Modulus(LanguageMode language_mode);
+
+  const Operator* UnaryNot(LanguageMode language_mode);

[Michael Starzinger, 2015/04/23 15:20:53]

The JSUnaryNot operator shouldn't require the language mode.

[conradw, 2015/04/23 16:08:02]

I thought the semantics involved ToBoolean? Currently in my followup CL this
will be another possible throwing implicit conversion.

@rossberg?

[rossberg, 2015/04/24 11:08:18]

ToBoolean is the one conversion that we will keep, so the mode is not needed
here.

[conradw, 2015/04/24 11:35:37]

Ah, I should have remembered. Done.

   const Operator* ToBoolean();
   const Operator* ToNumber();
   const Operator* ToString();