src/x87/lithium-codegen-x87.cc - Issue 1092353002: [strong] Disallow implicit conversions for binary arithmetic operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/lithium-codegen-x87.cc

Issue 1092353002: [strong] Disallow implicit conversions for binary arithmetic operations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase :( Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: src/x87/lithium-codegen-x87.cc

diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc

index 1aee565feb3acfd2aa5058aeecc464a45c8dc521..13dfc17345f028d757d61387854e54aed7deee8f 100644

--- a/src/x87/lithium-codegen-x87.cc

+++ b/src/x87/lithium-codegen-x87.cc

@@ -2346,7 +2346,8 @@ void LCodeGen::DoArithmeticT(LArithmeticT* instr) {

DCHECK(ToRegister(instr->right()).is(eax));

DCHECK(ToRegister(instr->result()).is(eax));

- Handle<Code> code = CodeFactory::BinaryOpIC(isolate(), instr->op()).code();

+ Handle<Code> code = CodeFactory::BinaryOpIC(

+ isolate(), instr->op(), language_mode()).code();

CallCode(code, RelocInfo::CODE_TARGET, instr);

}

« src/runtime.js ('K') | « src/x87/full-codegen-x87.cc ('k') | test/cctest/cctest.h » ('j') | test/cctest/cctest.h » ('J')