Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 1092353002: [strong] Disallow implicit conversions for binary arithmetic operations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 5 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2086 matching lines...) Expand 10 before | Expand all | Expand 10 after
2097 } 2097 }
2098 } 2098 }
2099 2099
2100 2100
2101 void LCodeGen::DoArithmeticT(LArithmeticT* instr) { 2101 void LCodeGen::DoArithmeticT(LArithmeticT* instr) {
2102 DCHECK(ToRegister(instr->context()).is(rsi)); 2102 DCHECK(ToRegister(instr->context()).is(rsi));
2103 DCHECK(ToRegister(instr->left()).is(rdx)); 2103 DCHECK(ToRegister(instr->left()).is(rdx));
2104 DCHECK(ToRegister(instr->right()).is(rax)); 2104 DCHECK(ToRegister(instr->right()).is(rax));
2105 DCHECK(ToRegister(instr->result()).is(rax)); 2105 DCHECK(ToRegister(instr->result()).is(rax));
2106 2106
2107 Handle<Code> code = CodeFactory::BinaryOpIC(isolate(), instr->op()).code(); 2107 Handle<Code> code = CodeFactory::BinaryOpIC(
2108 isolate(), instr->op(), language_mode()).code();
2108 CallCode(code, RelocInfo::CODE_TARGET, instr); 2109 CallCode(code, RelocInfo::CODE_TARGET, instr);
2109 } 2110 }
2110 2111
2111 2112
2112 template<class InstrType> 2113 template<class InstrType>
2113 void LCodeGen::EmitBranch(InstrType instr, Condition cc) { 2114 void LCodeGen::EmitBranch(InstrType instr, Condition cc) {
2114 int left_block = instr->TrueDestination(chunk_); 2115 int left_block = instr->TrueDestination(chunk_);
2115 int right_block = instr->FalseDestination(chunk_); 2116 int right_block = instr->FalseDestination(chunk_);
2116 2117
2117 int next_block = GetNextEmittedBlock(); 2118 int next_block = GetNextEmittedBlock();
(...skipping 3798 matching lines...) Expand 10 before | Expand all | Expand 10 after
5916 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5917 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5917 RecordSafepoint(Safepoint::kNoLazyDeopt); 5918 RecordSafepoint(Safepoint::kNoLazyDeopt);
5918 } 5919 }
5919 5920
5920 5921
5921 #undef __ 5922 #undef __
5922 5923
5923 } } // namespace v8::internal 5924 } } // namespace v8::internal
5924 5925
5925 #endif // V8_TARGET_ARCH_X64 5926 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698