[strong] Disallow implicit conversions for binary arithmetic operations

src/ic/ic-state.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_IC_STATE_H_
 #define V8_IC_STATE_H_
 
 #include "src/macro-assembler.h"
 
 namespace v8 {
@@ skipping 39 matching lines @@
   const CallType call_type_;
 };
 
 
 std::ostream& operator<<(std::ostream& os, const CallICState& s);
 
 
 class BinaryOpICState final BASE_EMBEDDED {
  public:
   BinaryOpICState(Isolate* isolate, ExtraICState extra_ic_state);
-
-  BinaryOpICState(Isolate* isolate, Token::Value op)
+  BinaryOpICState(Isolate* isolate, Token::Value op, LanguageMode language_mode)
       : op_(op),
+        strong_(is_strong(language_mode)),
         left_kind_(NONE),
         right_kind_(NONE),
         result_kind_(NONE),
         fixed_right_arg_(Nothing<int>()),
         isolate_(isolate) {
     DCHECK_LE(FIRST_TOKEN, op);
     DCHECK_LE(op, LAST_TOKEN);
   }
 
   InlineCacheState GetICState() const {
@@ skipping 26 matching lines @@
 
   // Returns true if the IC _should_ create allocation mementos.
   bool ShouldCreateAllocationMementos() const {
     return FLAG_allocation_site_pretenuring && CouldCreateAllocationMementos();
   }
 
   bool HasSideEffects() const {
     return Max(left_kind_, right_kind_) == GENERIC;
   }
 
+  LanguageMode language_mode() const {
+    return strong_ ? LanguageMode::STRONG : LanguageMode::SLOPPY;
+  }
+
   // Returns true if the IC should enable the inline smi code (i.e. if either
   // parameter may be a smi).
   bool UseInlinedSmiCode() const {
     return KindMaybeSmi(left_kind_) || KindMaybeSmi(right_kind_);
   }
 
   static const int FIRST_TOKEN = Token::BIT_OR;
   static const int LAST_TOKEN = Token::MOD;
 
   Token::Value op() const { return op_; }
@@ skipping 18 matching lines @@
   static Type* KindToType(Kind kind, Zone* zone);
   static bool KindMaybeSmi(Kind kind) {
     return (kind >= SMI && kind <= NUMBER) || kind == GENERIC;
   }
 
   // We truncate the last bit of the token.
   STATIC_ASSERT(LAST_TOKEN - FIRST_TOKEN < (1 << 4));
   class OpField : public BitField<int, 0, 4> {};
   class ResultKindField : public BitField<Kind, 4, 3> {};
   class LeftKindField : public BitField<Kind, 7, 3> {};
+  class StrongField : public BitField<bool, 10, 1> {};

[arv (Not doing code reviews), 2015/04/24 14:14:23]

We should update these to use kNext when we make changes to them.

   // When fixed right arg is set, we don't need to store the right kind.
   // Thus the two fields can overlap.
-  class HasFixedRightArgField : public BitField<bool, 10, 1> {};
-  class FixedRightArgValueField : public BitField<int, 11, 4> {};
-  class RightKindField : public BitField<Kind, 11, 3> {};
+  class HasFixedRightArgField : public BitField<bool, 11, 1> {};
+  class FixedRightArgValueField : public BitField<int, 12, 4> {};
+  class RightKindField : public BitField<Kind, 12, 3> {};
 
   Token::Value op_;
+  bool strong_;
   Kind left_kind_;
   Kind right_kind_;
   Kind result_kind_;
   Maybe<int> fixed_right_arg_;
   Isolate* isolate_;
 };
 
 
 std::ostream& operator<<(std::ostream& os, const BinaryOpICState& s);
 
@@ skipping 51 matching lines @@
  private:
   class ContextualModeBits : public BitField<ContextualMode, 0, 1> {};
   STATIC_ASSERT(static_cast<int>(NOT_CONTEXTUAL) == 0);
 
   const ExtraICState state_;
 };
 }
 }
 
 #endif  // V8_IC_STATE_H_