Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1092353002: [strong] Disallow implicit conversions for binary arithmetic operations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 5 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2057 matching lines...) Expand 10 before | Expand all | Expand 10 after
2068 } 2068 }
2069 } 2069 }
2070 2070
2071 2071
2072 void LCodeGen::DoArithmeticT(LArithmeticT* instr) { 2072 void LCodeGen::DoArithmeticT(LArithmeticT* instr) {
2073 DCHECK(ToRegister(instr->context()).is(esi)); 2073 DCHECK(ToRegister(instr->context()).is(esi));
2074 DCHECK(ToRegister(instr->left()).is(edx)); 2074 DCHECK(ToRegister(instr->left()).is(edx));
2075 DCHECK(ToRegister(instr->right()).is(eax)); 2075 DCHECK(ToRegister(instr->right()).is(eax));
2076 DCHECK(ToRegister(instr->result()).is(eax)); 2076 DCHECK(ToRegister(instr->result()).is(eax));
2077 2077
2078 Handle<Code> code = CodeFactory::BinaryOpIC(isolate(), instr->op()).code(); 2078 Handle<Code> code = CodeFactory::BinaryOpIC(
2079 isolate(), instr->op(), language_mode()).code();
2079 CallCode(code, RelocInfo::CODE_TARGET, instr); 2080 CallCode(code, RelocInfo::CODE_TARGET, instr);
2080 } 2081 }
2081 2082
2082 2083
2083 template<class InstrType> 2084 template<class InstrType>
2084 void LCodeGen::EmitBranch(InstrType instr, Condition cc) { 2085 void LCodeGen::EmitBranch(InstrType instr, Condition cc) {
2085 int left_block = instr->TrueDestination(chunk_); 2086 int left_block = instr->TrueDestination(chunk_);
2086 int right_block = instr->FalseDestination(chunk_); 2087 int right_block = instr->FalseDestination(chunk_);
2087 2088
2088 int next_block = GetNextEmittedBlock(); 2089 int next_block = GetNextEmittedBlock();
(...skipping 3649 matching lines...) Expand 10 before | Expand all | Expand 10 after
5738 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5739 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5739 RecordSafepoint(Safepoint::kNoLazyDeopt); 5740 RecordSafepoint(Safepoint::kNoLazyDeopt);
5740 } 5741 }
5741 5742
5742 5743
5743 #undef __ 5744 #undef __
5744 5745
5745 } } // namespace v8::internal 5746 } } // namespace v8::internal
5746 5747
5747 #endif // V8_TARGET_ARCH_IA32 5748 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ic/ic.h » ('j') | src/ic/ic.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698