[strong] Disallow implicit conversions for binary arithmetic operations

src/compiler/ast-graph-builder.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/ast-graph-builder.h"
 
 #include "src/compiler.h"
 #include "src/compiler/ast-loop-assignment-analyzer.h"
 #include "src/compiler/control-builders.h"
 #include "src/compiler/js-type-feedback.h"
@@ skipping 1251 matching lines @@
 
   // These stack values are renamed in the case of OSR, so reload them
   // from the environment.
   Node* index = environment()->Peek(0);
   Node* cache_length = environment()->Peek(1);
   Node* cache_array = environment()->Peek(2);
   Node* cache_type = environment()->Peek(3);
   Node* obj = environment()->Peek(4);
 
   // Check loop termination condition.
-  Node* exit_cond = NewNode(javascript()->LessThan(), index, cache_length);
+  Node* exit_cond = NewNode(javascript()->LessThan(LanguageMode::SLOPPY),
+                            index, cache_length);
   // TODO(jarin): provide real bailout id.
   PrepareFrameState(exit_cond, BailoutId::None());
   for_loop.BreakUnless(exit_cond);
   Node* pair = NewNode(javascript()->CallRuntime(Runtime::kForInNext, 4), obj,
                        cache_array, cache_type, index);
   Node* value = NewNode(common()->Projection(0), pair);
   Node* should_filter = NewNode(common()->Projection(1), pair);
   environment()->Push(value);
   {
     // Test if FILTER_KEY needs to be called.
@@ skipping 13 matching lines @@
                         function, obj, value);
     PrepareFrameState(res, stmt->FilterId(), OutputFrameStateCombine::Push());
     Node* property_missing =
         NewNode(javascript()->StrictEqual(), res, jsgraph()->ZeroConstant());
     {
       IfBuilder is_property_missing(this);
       is_property_missing.If(property_missing);
       is_property_missing.Then();
       // Inc counter and continue.
       Node* index_inc =
-          NewNode(javascript()->Add(), index, jsgraph()->OneConstant());
+          NewNode(javascript()->Add(LanguageMode::SLOPPY), index,
+                  jsgraph()->OneConstant());
       // TODO(jarin): provide real bailout id.
       PrepareFrameStateAfterAndBefore(index_inc, BailoutId::None(),
                                       OutputFrameStateCombine::Ignore(),
                                       jsgraph()->EmptyFrameState());
       environment()->Poke(0, index_inc);
       for_loop.Continue();
       is_property_missing.Else();
       is_property_missing.End();
     }
     // Replace 'value' in environment.
     environment()->Push(res);
     test_should_filter.Else();
     test_should_filter.End();
   }
   value = environment()->Pop();
   // Bind value and do loop body.
   VisitForInAssignment(stmt->each(), value, stmt->AssignmentId());
   VisitIterationBody(stmt, &for_loop);
   index = environment()->Peek(0);
   for_loop.EndBody();
 
   // Inc counter and continue.
   Node* index_inc =
-      NewNode(javascript()->Add(), index, jsgraph()->OneConstant());
+      NewNode(javascript()->Add(LanguageMode::SLOPPY), index,
+              jsgraph()->OneConstant());
   // TODO(jarin): provide real bailout id.
   PrepareFrameStateAfterAndBefore(index_inc, BailoutId::None(),
                                   OutputFrameStateCombine::Ignore(),
                                   jsgraph()->EmptyFrameState());
   environment()->Poke(0, index_inc);
   for_loop.EndLoop();
   environment()->Drop(5);
   // PrepareForBailoutForId(stmt->ExitId(), NO_REGISTERS);
 }
 
@@ skipping 1091 matching lines @@
     case Token::NE:
       op = javascript()->NotEqual();
       break;
     case Token::EQ_STRICT:
       op = javascript()->StrictEqual();
       break;
     case Token::NE_STRICT:
       op = javascript()->StrictNotEqual();
       break;
     case Token::LT:
-      op = javascript()->LessThan();
+      op = javascript()->LessThan(language_mode());
       break;
     case Token::GT:
-      op = javascript()->GreaterThan();
+      op = javascript()->GreaterThan(language_mode());
       break;
     case Token::LTE:
-      op = javascript()->LessThanOrEqual();
+      op = javascript()->LessThanOrEqual(language_mode());
       break;
     case Token::GTE:
-      op = javascript()->GreaterThanOrEqual();
+      op = javascript()->GreaterThanOrEqual(language_mode());
       break;
     case Token::INSTANCEOF:
       op = javascript()->InstanceOf();
       break;
     case Token::IN:
       op = javascript()->HasProperty();
       break;
     default:
       op = NULL;
       UNREACHABLE();
@@ skipping 739 matching lines @@
   Node* control = NewNode(common()->Throw(), exception_value);
   UpdateControlDependencyToLeaveFunction(control);
   return control;
 }
 
 
 Node* AstGraphBuilder::BuildBinaryOp(Node* left, Node* right, Token::Value op) {
   const Operator* js_op;
   switch (op) {
     case Token::BIT_OR:
-      js_op = javascript()->BitwiseOr();
+      js_op = javascript()->BitwiseOr(language_mode());
       break;
     case Token::BIT_AND:
-      js_op = javascript()->BitwiseAnd();
+      js_op = javascript()->BitwiseAnd(language_mode());
       break;
     case Token::BIT_XOR:
-      js_op = javascript()->BitwiseXor();
+      js_op = javascript()->BitwiseXor(language_mode());
       break;
     case Token::SHL:
-      js_op = javascript()->ShiftLeft();
+      js_op = javascript()->ShiftLeft(language_mode());
       break;
     case Token::SAR:
-      js_op = javascript()->ShiftRight();
+      js_op = javascript()->ShiftRight(language_mode());
       break;
     case Token::SHR:
-      js_op = javascript()->ShiftRightLogical();
+      js_op = javascript()->ShiftRightLogical(language_mode());
       break;
     case Token::ADD:
-      js_op = javascript()->Add();
+      js_op = javascript()->Add(language_mode());
       break;
     case Token::SUB:
-      js_op = javascript()->Subtract();
+      js_op = javascript()->Subtract(language_mode());
       break;
     case Token::MUL:
-      js_op = javascript()->Multiply();
+      js_op = javascript()->Multiply(language_mode());
       break;
     case Token::DIV:
-      js_op = javascript()->Divide();
+      js_op = javascript()->Divide(language_mode());
       break;
     case Token::MOD:
-      js_op = javascript()->Modulus();
+      js_op = javascript()->Modulus(language_mode());
       break;
     default:
       UNREACHABLE();
       js_op = NULL;
   }
   return NewNode(js_op, left, right);
 }
 
 
 bool AstGraphBuilder::CheckOsrEntry(IterationStatement* stmt) {
@@ skipping 327 matching lines @@
     // Phi does not exist yet, introduce one.
     value = NewPhi(inputs, value, control);
     value->ReplaceInput(inputs - 1, other);
   }
   return value;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8