Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Side by Side Diff: src/code-factory.cc

Issue 1092353002: [strong] Disallow implicit conversions for binary arithmetic operations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 5 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 10
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 105
106 106
107 // static 107 // static
108 Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op) { 108 Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op) {
109 Handle<Code> code = CompareIC::GetUninitialized(isolate, op); 109 Handle<Code> code = CompareIC::GetUninitialized(isolate, op);
110 return Callable(code, CompareDescriptor(isolate)); 110 return Callable(code, CompareDescriptor(isolate));
111 } 111 }
112 112
113 113
114 // static 114 // static
115 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op) { 115 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op,
116 BinaryOpICStub stub(isolate, op); 116 LanguageMode language_mode) {
117 BinaryOpICStub stub(isolate, op, language_mode);
117 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 118 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
118 } 119 }
119 120
120 121
121 // static 122 // static
122 Callable CodeFactory::ToBoolean(Isolate* isolate, 123 Callable CodeFactory::ToBoolean(Isolate* isolate,
123 ToBooleanStub::ResultMode mode, 124 ToBooleanStub::ResultMode mode,
124 ToBooleanStub::Types types) { 125 ToBooleanStub::Types types) {
125 ToBooleanStub stub(isolate, mode, types); 126 ToBooleanStub stub(isolate, mode, types);
126 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 127 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 167
167 // static 168 // static
168 Callable CodeFactory::CallFunction(Isolate* isolate, int argc, 169 Callable CodeFactory::CallFunction(Isolate* isolate, int argc,
169 CallFunctionFlags flags) { 170 CallFunctionFlags flags) {
170 CallFunctionStub stub(isolate, argc, flags); 171 CallFunctionStub stub(isolate, argc, flags);
171 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 172 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
172 } 173 }
173 174
174 } // namespace internal 175 } // namespace internal
175 } // namespace v8 176 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | src/ic/ic.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698