Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 1092353002: [strong] Disallow implicit conversions for binary arithmetic operations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 5 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-codegen-arm.h" 7 #include "src/arm/lithium-codegen-arm.h"
8 #include "src/arm/lithium-gap-resolver-arm.h" 8 #include "src/arm/lithium-gap-resolver-arm.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2156 matching lines...) Expand 10 before | Expand all | Expand 10 after
2167 } 2167 }
2168 } 2168 }
2169 2169
2170 2170
2171 void LCodeGen::DoArithmeticT(LArithmeticT* instr) { 2171 void LCodeGen::DoArithmeticT(LArithmeticT* instr) {
2172 DCHECK(ToRegister(instr->context()).is(cp)); 2172 DCHECK(ToRegister(instr->context()).is(cp));
2173 DCHECK(ToRegister(instr->left()).is(r1)); 2173 DCHECK(ToRegister(instr->left()).is(r1));
2174 DCHECK(ToRegister(instr->right()).is(r0)); 2174 DCHECK(ToRegister(instr->right()).is(r0));
2175 DCHECK(ToRegister(instr->result()).is(r0)); 2175 DCHECK(ToRegister(instr->result()).is(r0));
2176 2176
2177 Handle<Code> code = CodeFactory::BinaryOpIC(isolate(), instr->op()).code(); 2177 Handle<Code> code = CodeFactory::BinaryOpIC(
2178 isolate(), instr->op(), language_mode()).code();
2178 // Block literal pool emission to ensure nop indicating no inlined smi code 2179 // Block literal pool emission to ensure nop indicating no inlined smi code
2179 // is in the correct position. 2180 // is in the correct position.
2180 Assembler::BlockConstPoolScope block_const_pool(masm()); 2181 Assembler::BlockConstPoolScope block_const_pool(masm());
2181 CallCode(code, RelocInfo::CODE_TARGET, instr); 2182 CallCode(code, RelocInfo::CODE_TARGET, instr);
2182 } 2183 }
2183 2184
2184 2185
2185 template<class InstrType> 2186 template<class InstrType>
2186 void LCodeGen::EmitBranch(InstrType instr, Condition condition) { 2187 void LCodeGen::EmitBranch(InstrType instr, Condition condition) {
2187 int left_block = instr->TrueDestination(chunk_); 2188 int left_block = instr->TrueDestination(chunk_);
(...skipping 3721 matching lines...) Expand 10 before | Expand all | Expand 10 after
5909 __ Push(scope_info); 5910 __ Push(scope_info);
5910 __ push(ToRegister(instr->function())); 5911 __ push(ToRegister(instr->function()));
5911 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5912 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5912 RecordSafepoint(Safepoint::kNoLazyDeopt); 5913 RecordSafepoint(Safepoint::kNoLazyDeopt);
5913 } 5914 }
5914 5915
5915 5916
5916 #undef __ 5917 #undef __
5917 5918
5918 } } // namespace v8::internal 5919 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | src/ic/ic.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698