[strong] Disallow implicit conversions for binary arithmetic operations

test/unittests/compiler/js-typed-lowering-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-operator.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/machine-operator.h"
 #include "src/compiler/node-properties.h"
@@ skipping 96 matching lines @@
 
 
 // -----------------------------------------------------------------------------
 // JSUnaryNot
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithBoolean) {
   Node* input = Parameter(Type::Boolean(), 0);
   Node* context = Parameter(Type::Any(), 1);
   Reduction r =
-      Reduce(graph()->NewNode(javascript()->UnaryNot(), input, context));
+      Reduce(graph()->NewNode(javascript()->UnaryNot(LanguageMode::SLOPPY),
+                              input, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsBooleanNot(input));
 }
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithOrderedNumber) {
   Node* input = Parameter(Type::OrderedNumber(), 0);
   Node* context = Parameter(Type::Any(), 1);
   Reduction r =
-      Reduce(graph()->NewNode(javascript()->UnaryNot(), input, context));
+      Reduce(graph()->NewNode(javascript()->UnaryNot(LanguageMode::SLOPPY),
+                              input, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsNumberEqual(input, IsNumberConstant(0)));
 }
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithFalsish) {
   Node* input = Parameter(
       Type::Union(
           Type::MinusZero(),
           Type::Union(
               Type::NaN(),
               Type::Union(
                   Type::Null(),
                   Type::Union(
                       Type::Undefined(),
                       Type::Union(
                           Type::Undetectable(),
                           Type::Union(
                               Type::Constant(factory()->false_value(), zone()),
                               Type::Range(0.0, 0.0, zone()), zone()),
                           zone()),
                       zone()),
                   zone()),
               zone()),
           zone()),
       0);
   Node* context = Parameter(Type::Any(), 1);
   Reduction r =
-      Reduce(graph()->NewNode(javascript()->UnaryNot(), input, context));
+      Reduce(graph()->NewNode(javascript()->UnaryNot(LanguageMode::SLOPPY),
+                              input, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsTrueConstant());
 }
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithTruish) {
   Node* input = Parameter(
       Type::Union(
           Type::Constant(factory()->true_value(), zone()),
           Type::Union(Type::DetectableReceiver(), Type::Symbol(), zone()),
           zone()),
       0);
   Node* context = Parameter(Type::Any(), 1);
   Reduction r =
-      Reduce(graph()->NewNode(javascript()->UnaryNot(), input, context));
+      Reduce(graph()->NewNode(javascript()->UnaryNot(LanguageMode::SLOPPY),
+                              input, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsFalseConstant());
 }
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithNonZeroPlainNumber) {
   Node* input = Parameter(Type::Range(1.0, 42.0, zone()), 0);
   Node* context = Parameter(Type::Any(), 1);
   Reduction r =
-      Reduce(graph()->NewNode(javascript()->UnaryNot(), input, context));
+      Reduce(graph()->NewNode(javascript()->UnaryNot(LanguageMode::SLOPPY),
+                              input, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsFalseConstant());
 }
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithString) {
   Node* input = Parameter(Type::String(), 0);
   Node* context = Parameter(Type::Any(), 1);
   Reduction r =
-      Reduce(graph()->NewNode(javascript()->UnaryNot(), input, context));
+      Reduce(graph()->NewNode(javascript()->UnaryNot(LanguageMode::SLOPPY),
+                              input, context));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(
       r.replacement(),
       IsNumberEqual(IsLoadField(AccessBuilder::ForStringLength(zone()), input,
                                 graph()->start(), graph()->start()),
                     IsNumberConstant(0.0)));
 }
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithAny) {
   Node* input = Parameter(Type::Any(), 0);
   Node* context = Parameter(Type::Any(), 1);
   Reduction r =
-      Reduce(graph()->NewNode(javascript()->UnaryNot(), input, context));
+      Reduce(graph()->NewNode(javascript()->UnaryNot(LanguageMode::SLOPPY),
+                              input, context));
   ASSERT_FALSE(r.Changed());
 }
 
 
 // -----------------------------------------------------------------------------
 // Constant propagation
 
 
 TEST_F(JSTypedLoweringTest, ParameterWithMinusZero) {
   {
@@ skipping 232 matching lines @@
 // JSShiftLeft
 
 
 TEST_F(JSTypedLoweringTest, JSShiftLeftWithSigned32AndConstant) {
   Node* const lhs = Parameter(Type::Signed32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   TRACED_FORRANGE(double, rhs, 0, 31) {
     Reduction r =
-        Reduce(graph()->NewNode(javascript()->ShiftLeft(), lhs,
-                                NumberConstant(rhs), context, effect, control));
+        Reduce(graph()->NewNode(javascript()->ShiftLeft(LanguageMode::SLOPPY),
+                                lhs, NumberConstant(rhs), context, effect,
+                                control));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsWord32Shl(lhs, IsNumberConstant(BitEq(rhs))));
   }
 }
 
 
 TEST_F(JSTypedLoweringTest, JSShiftLeftWithSigned32AndUnsigned32) {
   Node* const lhs = Parameter(Type::Signed32());
   Node* const rhs = Parameter(Type::Unsigned32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
-  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftLeft(), lhs, rhs,
-                                        context, effect, control));
+  Reduction r = Reduce(graph()->NewNode(javascript()->
+                                        ShiftLeft(LanguageMode::SLOPPY),
+                                        lhs, rhs, context, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
               IsWord32Shl(lhs, IsWord32And(rhs, IsInt32Constant(0x1f))));
 }
 
 
 // -----------------------------------------------------------------------------
 // JSShiftRight
 
 
 TEST_F(JSTypedLoweringTest, JSShiftRightWithSigned32AndConstant) {
   Node* const lhs = Parameter(Type::Signed32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   TRACED_FORRANGE(double, rhs, 0, 31) {
     Reduction r =
-        Reduce(graph()->NewNode(javascript()->ShiftRight(), lhs,
+        Reduce(graph()->NewNode(javascript()->
+                                ShiftRight(LanguageMode::SLOPPY), lhs,
                                 NumberConstant(rhs), context, effect, control));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsWord32Sar(lhs, IsNumberConstant(BitEq(rhs))));
   }
 }
 
 
 TEST_F(JSTypedLoweringTest, JSShiftRightWithSigned32AndUnsigned32) {
   Node* const lhs = Parameter(Type::Signed32());
   Node* const rhs = Parameter(Type::Unsigned32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
-  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRight(), lhs, rhs,
-                                        context, effect, control));
+  Reduction r = Reduce(graph()->NewNode(javascript()->
+                                        ShiftRight(LanguageMode::SLOPPY),
+                                        lhs, rhs, context, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
               IsWord32Sar(lhs, IsWord32And(rhs, IsInt32Constant(0x1f))));
 }
 
 
 // -----------------------------------------------------------------------------
 // JSShiftRightLogical
 
 
-TEST_F(JSTypedLoweringTest, JSShiftRightLogicalWithUnsigned32AndConstant) {
+TEST_F(JSTypedLoweringTest,
+                   JSShiftRightLogicalWithUnsigned32AndConstant) {
   Node* const lhs = Parameter(Type::Unsigned32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
   TRACED_FORRANGE(double, rhs, 0, 31) {
     Reduction r =
-        Reduce(graph()->NewNode(javascript()->ShiftRightLogical(), lhs,
-                                NumberConstant(rhs), context, effect, control));
+        Reduce(graph()->NewNode(javascript()->
+                                ShiftRightLogical(LanguageMode::SLOPPY),
+                                lhs, NumberConstant(rhs), context, effect,
+                                control));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsWord32Shr(lhs, IsNumberConstant(BitEq(rhs))));
   }
 }
 
 
-TEST_F(JSTypedLoweringTest, JSShiftRightLogicalWithUnsigned32AndUnsigned32) {
+TEST_F(JSTypedLoweringTest,
+                   JSShiftRightLogicalWithUnsigned32AndUnsigned32) {
   Node* const lhs = Parameter(Type::Unsigned32());
   Node* const rhs = Parameter(Type::Unsigned32());
   Node* const context = UndefinedConstant();
   Node* const effect = graph()->start();
   Node* const control = graph()->start();
-  Reduction r = Reduce(graph()->NewNode(javascript()->ShiftRightLogical(), lhs,
-                                        rhs, context, effect, control));
+  Reduction r = Reduce(graph()->NewNode(javascript()->
+                                        ShiftRightLogical(LanguageMode::SLOPPY),
+                                        lhs, rhs, context, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
               IsWord32Shr(lhs, IsWord32And(rhs, IsInt32Constant(0x1f))));
 }
 
 
 // -----------------------------------------------------------------------------
 // JSLoadContext
 
 
@@ skipping 314 matching lines @@
                                 context, EmptyFrameState(), effect, control));
 
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), matches[i]);
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8