[strong] Disallow implicit conversions for binary arithmetic operations

src/compiler/js-typed-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/operator-properties.h"
@@ skipping 325 matching lines @@
     r.ConvertInputsToString();
     return r.ChangeToPureOperator(simplified()->StringAdd());
   }
 #endif
   return NoChange();
 }
 
 
 Reduction JSTypedLowering::ReduceNumberBinop(Node* node,
                                              const Operator* numberOp) {
+  if (is_strong(OpParameter<LanguageMode>(node))) {
+    return ReduceStrongNumberBinop(node, numberOp);

[rossberg, 2015/04/23 13:29:37]

I'd just inline the function.

[Michael Starzinger, 2015/04/23 13:47:52]

+1

[conradw, 2015/04/23 14:51:54]

Done.

+  }
   JSBinopReduction r(this, node);
   Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
   r.ConvertInputsToNumber(frame_state);
   return r.ChangeToPureOperator(numberOp, Type::Number());
 }
 
+Reduction JSTypedLowering::ReduceStrongNumberBinop(Node* node,
+                                             const Operator* numberOp) {
+  JSBinopReduction r(this, node);
+  if (r.left_type()->Is(Type::Number()) &&
+      (r.right_type()->Is(Type::Number()))) {
+    return r.ChangeToPureOperator(numberOp, Type::Number());
+  }
+  return NoChange();
+}
+
 
 Reduction JSTypedLowering::ReduceInt32Binop(Node* node, const Operator* intOp) {
   JSBinopReduction r(this, node);
   Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
   r.ConvertInputsToNumber(frame_state);
   r.ConvertInputsToUI32(kSigned, kSigned);
   return r.ChangeToPureOperator(intOp, Type::Integral32());
 }
 
 
@@ skipping 707 matching lines @@
 }
 
 
 MachineOperatorBuilder* JSTypedLowering::machine() const {
   return jsgraph()->machine();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8