Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1092323003: Disable mjsunit/es7/object-observe on gc-stress, due to flakiness. (Closed)

Created:
5 years, 8 months ago by vogelheim
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable mjsunit/es7/object-observe on gc-stress, due to flakiness. TBR=machenbach@chromium.org CC=adamk@chromium.org BUG=478788 LOG=N Committed: https://chromium.googlesource.com/v8/v8/+/abb23b5284d94278f1c16a4e051b47cc44e993e8

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abb23b5284d94278f1c16a4e051b47cc44e993e8 Cr-Commit-Position: refs/heads/master@{#27948}
5 years, 8 months ago (2015-04-20 18:15:10 UTC) #1
vogelheim
Committed patchset #1 (id:1) manually as abb23b5284d94278f1c16a4e051b47cc44e993e8 (presubmit successful).
5 years, 8 months ago (2015-04-20 18:15:11 UTC) #2
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-20 20:58:21 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1092323003/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1092323003/diff/1/test/mjsunit/mjsunit.status#newcode289 test/mjsunit/mjsunit.status:289: 'mjsunit/es7/object-observe': [SKIP], Hum - looking more closely: the prefix ...
5 years, 8 months ago (2015-04-21 21:02:53 UTC) #4
adamk
5 years, 8 months ago (2015-04-21 23:22:05 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1092323003/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/1092323003/diff/1/test/mjsunit/mjsunit.status...
test/mjsunit/mjsunit.status:289: 'mjsunit/es7/object-observe': [SKIP],
On 2015/04/21 21:02:52, Michael Achenbach wrote:
> Hum - looking more closely: the prefix "mjsunit/" is wrong and the test is not
> skipped. The two expectations above are also wrong.

Has it been failing?

Powered by Google App Engine
This is Rietveld 408576698