[Chromecast] CastSysInfo implementation.

chromecast/chromecast.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'android_support_v13_target%':
         '../third_party/android_tools/android_tools.gyp:android_support_v13_javalib',
     'cast_build_release': 'internal/build/cast_build_release',
     'cast_is_debug_build%': 0,
@@ skipping 20 matching lines @@
     ],
   },
   'targets': [
     # Public API target for OEM partners to replace shlibs.
     {
       'target_name': 'cast_public_api',
       'type': '<(component)',
       'sources': [
         'public/cast_egl_platform.h',
         'public/cast_egl_platform_shlib.h',
+        'public/cast_sys_info.h',
         'public/chromecast_export.h',
         'public/graphics_properties_shlib.h'
       ],
     },
     # TODO(gunsch): Remove this fake target once it's either added or no
     # longer referenced from internal code.
     {'target_name': 'cast_media_audio', 'type': 'none'},
 
     {
       'target_name': 'cast_base',
@@ skipping 119 matching lines @@
     # non-platform-specific.
     {
       'target_name': 'cast_shell_common',
       'type': '<(component)',
       'dependencies': [
         'cast_base',
         'cast_crash_client',
         'cast_net',
         'cast_shell_pak',
         'cast_shell_resources',
+        'cast_sys_info',
         'cast_version_header',
         'chromecast_locales.gyp:chromecast_locales_pak',
         'chromecast_locales.gyp:chromecast_settings',
         'media/media.gyp:media_base',
         '../base/base.gyp:base',
         '../components/components.gyp:breakpad_host',
         '../components/components.gyp:cdm_renderer',
         '../components/components.gyp:component_metrics_proto',
         '../components/components.gyp:crash_component',
         '../components/components.gyp:network_hints_browser',
@@ skipping 114 matching lines @@
             'browser/metrics/external_metrics.cc',
             'browser/metrics/external_metrics.h',
           ],
           'dependencies': [
             '../components/components.gyp:metrics_serialization',
           ],
         }],
       ],
     },
     {
+      'target_name': 'cast_sys_info',
+      'type': '<(component)',
+      'dependencies': [
+        'cast_public_api',
+        '../base/base.gyp:base',
+      ],
+      'sources': [
+        'base/cast_sys_info.h',

[lcwu1, 2015/04/22 21:57:54]

I think having the same name here (as the one in public/) is confusing. I would
suggest changing it to something like create_sys_info.h. (Or if we expect to add
additional utils to this file, maybe something like cast_sys_info_util.h.)

[derekjchow1, 2015/04/22 22:22:04]

Done.

+        'base/cast_sys_info_dummy.cc',
+        'base/cast_sys_info_dummy.h',
+      ],
+      'conditions': [
+        ['chromecast_branding!="Chrome"', {
+          'sources': [
+            'base/cast_sys_info_simple.cc',
+          ],
+        }],
+      ],
+    },  # end of target 'cast_sys_info'
+    {
       'target_name': 'cast_version_header',
       'type': 'none',
       'direct_dependent_settings': {
         'include_dirs': [
           '<(SHARED_INTERMEDIATE_DIR)',
         ],
       },
       'actions': [
         {
           'action_name': 'version_header',
@@ skipping 266 matching lines @@
           ],
           'sources': [
             'graphics/cast_egl_platform_default.cc',
             'graphics/graphics_properties_default.cc'
           ],
         }
       ]
     }],
   ],  # end of conditions
 }