[Chromecast] CastSysInfo implementation.

chromecast/public/cast_sys_info_shlib.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMECAST_PUBLIC_CAST_SYS_INFO_SHLIB_H_
+#define CHROMECAST_PUBLIC_CAST_SYS_INFO_SHLIB_H_
+
+#include <string>
+#include <vector>
+
+#include "chromecast_export.h"
+
+namespace chromecast {
+
+class CastSysInfo;
+
+// Defines a static function in a class since gcc makes warning if visibility

[gunsch, 2015/04/20 22:34:49]

Still: this is not really a good definition of this class. If anything, this was
appropriate as a review mail to explain during this header's initial review, but
doesn't belong with the code once checked in.

[byungchul, 2015/04/20 23:51:14]

Agree that this is not a comment to define this. But, at the same item, this is
the only purpose of this class, and should be here for those who will see this
code in the future.
Does it work for you if it is rephrased like:

A static class for CastSysInfo shared library visible from cast_shell. gcc makes
warning if visibility attribute is set on global functions.

?

[derekjchow1, 2015/04/21 21:48:34]

Done.

+// attribute is set on global functions.
+class CHROMECAST_EXPORT CastSysInfoShlib {
+ public:
+  // Returns a instance of CastSysInfo for the platform from a shared library.
+  // Caller will take ownership of returned pointer.
+  static CastSysInfo* Create(const std::vector<std::string>& argv);
+};
+
+}  // namespace chromecast
+
+#endif  // CHROMECAST_PUBLIC_CAST_SYS_INFO_SHLIB_H_