[Chromecast] CastSysInfo implementation.

chromecast/public/cast_sys_info_shlib.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMECAST_PUBLIC_CAST_SYS_INFO_SHLIB_H_
+#define CHROMECAST_PUBLIC_CAST_SYS_INFO_SHLIB_H_
+
+#include <string>
+#include <vector>
+
+#include "chromecast_export.h"
+
+namespace chromecast {
+
+class CastSysInfo;
+
+// Defines a static function in a class since gcc makes warning if visibility
+// attribute is set on global functions.
+class CHROMECAST_EXPORT CastSysInfoShlib {
+ public:
+  static CastSysInfo* Create(const std::vector<std::string>& argv);

[byungchul, 2015/04/20 18:00:24]

You should have cast_sys_info_shlib.cc:

CastSysInfo* CastSysInfo::Create() {
  return CastSysInfoShlib::Create(
      base::CommandLine::ForCurrentProcess()->argv());
}

[byungchul, 2015/04/20 23:51:14]

ping on this comment~

[derekjchow1, 2015/04/21 21:48:33]

As discussed offline we might statically link cast_sys_info.

+};
+
+}  // namespace chromecast
+
+#endif  // CHROMECAST_PUBLIC_CAST_SYS_INFO_SHLIB_H_