Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1092283002: Add support for rotating / scaling / translating gpu cached distance field textblobs (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@atdfopt3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add support for rotating / scaling / translating gpu cached distance field textblobs BUG=skia: Committed: https://skia.googlesource.com/skia/+/64c99cc90e678feba473d38db420d31883cc53e6

Patch Set 1 #

Patch Set 2 : tidy #

Patch Set 3 : distance field cached textblob can regenerate #

Patch Set 4 : adding comment #

Total comments: 2

Patch Set 5 : adding comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 2 3 4 2 chunks +13 lines, -3 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 6 chunks +44 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-20 20:17:40 UTC) #2
jvanverth1
LGTM + comments https://codereview.chromium.org/1092283002/diff/60001/src/gpu/GrAtlasTextContext.cpp File src/gpu/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1092283002/diff/60001/src/gpu/GrAtlasTextContext.cpp#newcode629 src/gpu/GrAtlasTextContext.cpp:629: // minMaxScale to make regeneration decisions ...
5 years, 8 months ago (2015-04-21 15:29:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092283002/80001
5 years, 8 months ago (2015-04-21 16:06:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092283002/80001
5 years, 8 months ago (2015-04-21 16:38:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 16:43:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/64c99cc90e678feba473d38db420d31883cc53e6

Powered by Google App Engine
This is Rietveld 408576698