Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1092253003: Fix serialization statistics for external strings. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix serialization statistics for external strings. External strings are serialized as internal strings. The current way of collecting stats is slightly wrong. We ought to use the map and size passed to SerializePrologue. R=jkummerow@chromium.org Committed: https://crrev.com/e96d25536ea2a84459ff5cec531727e8f53ca5d9 Cr-Commit-Position: refs/heads/master@{#27931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/snapshot/serialize.h View 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 8 months ago (2015-04-20 06:47:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092253003/1
5 years, 8 months ago (2015-04-20 06:48:17 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-20 07:32:35 UTC) #5
Jakob Kummerow
If you say so... LGTM.
5 years, 8 months ago (2015-04-20 08:52:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092253003/1
5 years, 8 months ago (2015-04-20 08:55:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 08:55:21 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 08:55:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e96d25536ea2a84459ff5cec531727e8f53ca5d9
Cr-Commit-Position: refs/heads/master@{#27931}

Powered by Google App Engine
This is Rietveld 408576698