Handle typographical apostrophe with spelling service client

chrome/renderer/spellchecker/spellcheck_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
@@ skipping 1122 matching lines @@
     base::string16 text = base::ASCIIToUTF16("zz");
     std::vector<SpellCheckResult> spellcheck_results;
     spellcheck_results.push_back(SpellCheckResult(
         SpellCheckResult::SPELLING, 0, 2, base::string16()));
     blink::WebVector<blink::WebTextCheckingResult> textcheck_results;
     spell_check()->CreateTextCheckingResults(SpellCheck::USE_NATIVE_CHECKER,
                                              0,
                                              text,
                                              spellcheck_results,
                                              &textcheck_results);
-    EXPECT_EQ(spellcheck_results.size(), textcheck_results.size());
+    ASSERT_EQ(spellcheck_results.size(), textcheck_results.size());
     EXPECT_EQ(blink::WebTextDecorationTypeSpelling,
               textcheck_results[0].decoration);
     EXPECT_EQ(spellcheck_results[0].location, textcheck_results[0].location);
     EXPECT_EQ(spellcheck_results[0].length, textcheck_results[0].length);
   }
 
   // Verify that the SpellCheck class replaces the spelling marker added to a
   // contextually-misspelled word "bean" with a grammar marker.
   {
     base::string16 text = base::ASCIIToUTF16("I have bean to USA.");
     std::vector<SpellCheckResult> spellcheck_results;
     spellcheck_results.push_back(SpellCheckResult(
         SpellCheckResult::SPELLING, 7, 4, base::string16()));
     blink::WebVector<blink::WebTextCheckingResult> textcheck_results;
     spell_check()->CreateTextCheckingResults(SpellCheck::USE_NATIVE_CHECKER,
                                              0,
                                              text,
                                              spellcheck_results,
                                              &textcheck_results);
-    EXPECT_EQ(spellcheck_results.size(), textcheck_results.size());
+    ASSERT_EQ(spellcheck_results.size(), textcheck_results.size());
     EXPECT_EQ(blink::WebTextDecorationTypeGrammar,
               textcheck_results[0].decoration);
     EXPECT_EQ(spellcheck_results[0].location, textcheck_results[0].location);
     EXPECT_EQ(spellcheck_results[0].length, textcheck_results[0].length);
   }
+
+  // Verify that the SpellCheck class removes the spelling marker caused only by
+  // a typographical apostrophe.
+  {
+    base::string16 text =
+        base::WideToUTF16(L"I\x2019ve bean here before, hasn\x2019t I?");
+    std::vector<SpellCheckResult> spellcheck_results;
+
+    // Typographical apostrophe correction should be ignored.
+    spellcheck_results.push_back(SpellCheckResult(
+        SpellCheckResult::SPELLING, 0, 4, base::ASCIIToUTF16("I've")));
+
+    // Contextual mistake should be marked as grammar mistake.
+    spellcheck_results.push_back(SpellCheckResult(
+        SpellCheckResult::SPELLING, 5, 4, base::ASCIIToUTF16("been")));
+
+    // Contextual mistake in addition to a typographical apostrophe correction
+    // should be marked as grammar mistake.
+    spellcheck_results.push_back(SpellCheckResult(
+        SpellCheckResult::SPELLING, 23, 6, base::ASCIIToUTF16("haven't")));
+
+    blink::WebVector<blink::WebTextCheckingResult> textcheck_results;
+    spell_check()->CreateTextCheckingResults(SpellCheck::USE_NATIVE_CHECKER,
+                                             0,
+                                             text,
+                                             spellcheck_results,
+                                             &textcheck_results);
+    ASSERT_EQ(2UL, textcheck_results.size());
+
+    EXPECT_EQ(blink::WebTextDecorationTypeGrammar,
+              textcheck_results[0].decoration);
+    EXPECT_EQ(spellcheck_results[1].location, textcheck_results[0].location);
+    EXPECT_EQ(spellcheck_results[1].length, textcheck_results[0].length);
+
+    EXPECT_EQ(blink::WebTextDecorationTypeGrammar,
+              textcheck_results[1].decoration);
+    EXPECT_EQ(spellcheck_results[2].location, textcheck_results[1].location);
+    EXPECT_EQ(spellcheck_results[2].length, textcheck_results[1].length);
+  }
 }
 
 #endif
 
 // Checks some words that should be present in all English dictionaries.
 TEST_F(SpellCheckTest, EnglishWords) {
   static const struct {
     const char* input;
     bool should_pass;
   } kTestCases[] = {
@@ skipping 187 matching lines @@
         strlen(kTestCases[i].misspelled),
         0,
         &misspelling_start,
         &misspelling_length,
         &suggestions));
     EXPECT_GE(suggestions.size(), static_cast<size_t>(1));
     if (suggestions.size() > 0)
       EXPECT_EQ(suggestions[0], base::ASCIIToUTF16(kTestCases[i].suggestion));
   }
 }