Handle typographical apostrophe with spelling service client

chrome/browser/spellchecker/spelling_service_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spelling_service_client.h"
 
 #include "base/json/json_reader.h"
 #include "base/json/string_escape.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
@@ skipping 48 matching lines @@
   const PrefService* pref = user_prefs::UserPrefs::Get(context);
   DCHECK(pref);
 
   std::string language_code;
   std::string country_code;
   chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(
       pref->GetString(prefs::kSpellCheckDictionary),
       &language_code,
       &country_code);
 
+  // Replace typographical apostrophes with typewriter apostrophes, so that
+  // server word breaker behaves correctly.
+  base::string16 text_copy = text;
+  for (base::char16& c : text_copy) {

[groby-ooo-7-16, 2015/06/17 19:12:02]

std::replace(text_copy.begin(), text_copy.end(), L'\x2019', '\');  // should
work as well

[please use gerrit instead, 2015/06/17 20:21:35]

Ooh, I like.

+    if (c == L'\x2019')
+      c = '\'';
+  }
+
   // Format the JSON request to be sent to the Spelling service.
-  std::string encoded_text = base::GetQuotedJSONString(text);
+  std::string encoded_text = base::GetQuotedJSONString(text_copy);
 
   static const char kSpellingRequest[] =
       "{"
       "\"method\":\"spelling.check\","
       "\"apiVersion\":\"v%d\","
       "\"params\":{"
       "\"text\":%s,"
       "\"language\":\"%s\","
       "\"originCountry\":\"%s\","
       "\"key\":%s"
@@ skipping 169 matching lines @@
 
   // The callback may release the last (transitive) dependency on |this|. It
   // MUST be the last function called.
   callback_data->callback.Run(success, callback_data->text, results);
 }
 
 scoped_ptr<net::URLFetcher> SpellingServiceClient::CreateURLFetcher(
     const GURL& url) {
   return net::URLFetcher::Create(url, net::URLFetcher::POST, this);
 }