Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issue 1092223006: [chrome/browser/profiles] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, rginda+watch_chromium.org, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/profiles BUG=466848 Committed: https://crrev.com/2d07d57aa5d38ff0cad8906cb1520bb814b0d917 Cr-Commit-Position: refs/heads/master@{#327072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -64 lines) Patch
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-27 10:21:57 UTC) #2
Elliot Glaysher
rubber stamp lgtm
5 years, 8 months ago (2015-04-27 17:25:47 UTC) #3
anujsharma
On 2015/04/27 17:25:47, Elliot Glaysher wrote: > rubber stamp lgtm Thanks Elliot for lgtm.
5 years, 8 months ago (2015-04-27 17:31:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092223006/1
5 years, 8 months ago (2015-04-27 17:33:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 18:12:59 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:13:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d07d57aa5d38ff0cad8906cb1520bb814b0d917
Cr-Commit-Position: refs/heads/master@{#327072}

Powered by Google App Engine
This is Rietveld 408576698