Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1092193003: [PresentationAPI] Added on-session-text-message handler. (Closed)

Created:
5 years, 8 months ago by haibinlu
Modified:
5 years, 7 months ago
Reviewers:
whywhat
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[PresentationAPI] Added on-session-text-message handler. Chromium change: https://codereview.chromium.org/1084293004/ BUG=459008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194625

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Forward declare WebString in WebPresentationController.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M Source/modules/presentation/Presentation.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/presentation/Presentation.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationController.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/PresentationController.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationSession.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationSession.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M public/platform/modules/presentation/WebPresentationController.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
haibinlu
5 years, 8 months ago (2015-04-22 01:08:05 UTC) #2
whywhat
lgtm
5 years, 8 months ago (2015-04-23 16:52:55 UTC) #3
whywhat
On 2015/04/23 at 16:52:55, whywhat wrote: > lgtm Although look at the Chromium change first ...
5 years, 8 months ago (2015-04-23 16:53:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092193003/1
5 years, 7 months ago (2015-04-28 19:52:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43304)
5 years, 7 months ago (2015-04-28 20:00:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092193003/20001
5 years, 7 months ago (2015-04-28 20:25:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/34201)
5 years, 7 months ago (2015-04-28 20:35:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092193003/40001
5 years, 7 months ago (2015-04-28 21:11:46 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 22:22:50 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194625

Powered by Google App Engine
This is Rietveld 408576698