Issue 1092183003: Handle calls through call methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1092183003: Handle calls through call methods (Closed)

Created:
5 years, 8 months ago by Leaf

Modified:
5 years, 8 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Handle calls through call methods This CL makes us recognizes calls through call methods as not requiring dynamic invokes. The analyzer seems to do the wrong thing on the return types though, so we'll still get casts on the results. Bug filed here: dartbug.com/23252 . This fixes #7. BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0f472e54349da8ce506df223b664deaa7c33eab2

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -19 lines)			Patch
M	lib/src/checker/checker.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/src/checker/rules.dart	View	3 chunks	+32 lines, -16 lines	0 comments	Download
M	test/checker/checker_test.dart	View	2 chunks	+50 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Leaf

5 years, 8 months ago (2015-04-17 23:37:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f472e54349da8ce506df223b664deaa7c33eab2 (presubmit successful).