Ignore non-ASCII headers in the mimeHandlerPrivate API.

Ignore non-ASCII headers in the mimeHandlerPrivate API.

BUG=477971
Committed: https://crrev.com/17a2e3a0efda2fedfb29f78a71b748a3fa98c39b
Cr-Commit-Position: refs/heads/master@{#326207}

[Sam McNally, 2015-04-20 05:30:15]

sammc@chromium.org changed reviewers:
+ benwells@chromium.org

[Sam McNally, 2015-04-20 06:19:46]

sammc@chromium.org changed reviewers:
+ raymes@chromium.org
- benwells@chromium.org

[Sam McNally, 2015-04-20 06:19:47]

+raymes

[raymes, 2015-04-20 23:18:45]

https://codereview.chromium.org/1092163004/diff/1/extensions/browser/api/mime...
File extensions/browser/api/mime_handler_private/mime_handler_private.cc
(right):

https://codereview.chromium.org/1092163004/diff/1/extensions/browser/api/mime...
extensions/browser/api/mime_handler_private/mime_handler_private.cc:29: // that
aren't ASCII.
I think we should add a comment with justification for why we can drop these
headers.

[Sam McNally, 2015-04-21 00:45:14]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2015-04-21 00:45:32]

https://codereview.chromium.org/1092163004/diff/1/extensions/browser/api/mime...
File extensions/browser/api/mime_handler_private/mime_handler_private.cc
(right):

https://codereview.chromium.org/1092163004/diff/1/extensions/browser/api/mime...
extensions/browser/api/mime_handler_private/mime_handler_private.cc:29: // that
aren't ASCII.
On 2015/04/20 23:18:45, raymes wrote:
> I think we should add a comment with justification for why we can drop these
> headers.

Done.

[raymes, 2015-04-21 01:00:07]

https://codereview.chromium.org/1092163004/diff/40001/extensions/browser/api/...
File extensions/browser/api/mime_handler_private/mime_handler_private.cc
(right):

https://codereview.chromium.org/1092163004/diff/40001/extensions/browser/api/...
extensions/browser/api/mime_handler_private/mime_handler_private.cc:31: // does
use.
What would be the correct fix? Should we file a bug in case this has an effect
on other users of MimeHandlerView?

[Sam McNally, 2015-04-21 03:17:32]

Patchset #3 (id:60001) has been deleted

[Sam McNally, 2015-04-21 03:18:40]

Patchset #3 (id:80001) has been deleted

[Sam McNally, 2015-04-21 03:18:55]

https://codereview.chromium.org/1092163004/diff/40001/extensions/browser/api/...
File extensions/browser/api/mime_handler_private/mime_handler_private.cc
(right):

https://codereview.chromium.org/1092163004/diff/40001/extensions/browser/api/...
extensions/browser/api/mime_handler_private/mime_handler_private.cc:31: // does
use.
On 2015/04/21 01:00:07, raymes wrote:
> What would be the correct fix? Should we file a bug in case this has an effect
> on other users of MimeHandlerView?

Added a TODO and mentioned it in the mojom and idl.

[raymes, 2015-04-21 03:31:27]

lgtm

[Sam McNally, 2015-04-21 03:33:51]

sammc@chromium.org changed reviewers:
+ benwells@chromium.org

[Sam McNally, 2015-04-21 03:33:52]

+benwells again for the mojom and idl changes.

[benwells, 2015-04-21 05:06:11]

lgtm

[Sam McNally, 2015-04-21 05:07:19]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2015-04-21 05:07:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092163004/100001

[raymes, 2015-04-21 05:13:50]

Could we add a test for this easily in mime_handler_view_browsertest.cc?

[Sam McNally, 2015-04-21 05:52:21]

The CQ bit was unchecked by sammc@chromium.org

[Sam McNally, 2015-04-21 06:51:27]

Patchset #4 (id:120001) has been deleted

[Sam McNally, 2015-04-21 06:51:55]

On 2015/04/21 05:13:50, raymes wrote:
> Could we add a test for this easily in mime_handler_view_browsertest.cc?

Yes. Done.

[raymes, 2015-04-22 00:18:12]

lgtm thanks!!

[raymes, 2015-04-22 00:18:12]

lgtm thanks!!

[Sam McNally, 2015-04-22 00:19:28]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2015-04-22 00:19:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/1092163004/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-04-22 00:19:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092163004/140001

[commit-bot: I haz the power, 2015-04-22 01:14:34]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-04-22 01:16:19]

Patchset 4 (id:??) landed as
https://crrev.com/17a2e3a0efda2fedfb29f78a71b748a3fa98c39b
Cr-Commit-Position: refs/heads/master@{#326207}