Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: Source/core/inspector/InspectorResourceAgent.cpp

Issue 1092123004: DevTools: remove dependency of most agents on InspectorPageAgent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: further cuts on InspectorPageAgent inter-agents API Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorResourceAgent.cpp
diff --git a/Source/core/inspector/InspectorResourceAgent.cpp b/Source/core/inspector/InspectorResourceAgent.cpp
index 2488f294087110d5d56c6d6a6793b99dff947b7e..b7d5c98eb85e3e62373977d6e65fb266aabcfabb 100644
--- a/Source/core/inspector/InspectorResourceAgent.cpp
+++ b/Source/core/inspector/InspectorResourceAgent.cpp
@@ -308,7 +308,7 @@ InspectorResourceAgent::~InspectorResourceAgent()
DEFINE_TRACE(InspectorResourceAgent)
{
- visitor->trace(m_pageAgent);
+ visitor->trace(m_inspectedFrame);
#if ENABLE(OILPAN)
visitor->trace(m_pendingXHRReplayData);
visitor->trace(m_replayXHRs);
@@ -543,7 +543,7 @@ void InspectorResourceAgent::didFinishXHRLoading(ExecutionContext* context, XMLH
String message = "XHR finished loading: " + method + " \"" + url + "\".";
RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(NetworkMessageSource, DebugMessageLevel, message);
consoleMessage->setRequestIdentifier(identifier);
- m_pageAgent->frameHost()->consoleMessageStorage().reportMessage(context, consoleMessage.release());
+ m_inspectedFrame->host()->consoleMessageStorage().reportMessage(context, consoleMessage.release());
}
}
@@ -735,7 +735,8 @@ bool InspectorResourceAgent::getResponseBodyBlob(const String& requestId, PassRe
if (!resourceData)
return false;
if (BlobDataHandle* blob = resourceData->downloadedFileBlob()) {
- if (LocalFrame* frame = m_pageAgent->frameForId(resourceData->frameId())) {
+ LocalFrame* frame = InspectorIdentifiers<LocalFrame>::lookup(resourceData->frameId());
+ if (frame && frame->instrumentingAgents() == m_inspectedFrame->instrumentingAgents()) {
if (Document* document = frame->document()) {
InspectorFileReaderLoaderClient* client = new InspectorFileReaderLoaderClient(blob, InspectorPageAgent::createResourceTextDecoder(resourceData->mimeType(), resourceData->textEncodingName()), callback);
client->start(document);
@@ -841,7 +842,7 @@ void InspectorResourceAgent::setCacheDisabled(ErrorString*, bool cacheDisabled)
m_state->setBoolean(ResourceAgentState::cacheDisabled, cacheDisabled);
if (cacheDisabled)
memoryCache()->evictResources();
- for (Frame* frame = m_pageAgent->inspectedFrame(); frame; frame = frame->tree().traverseNext()) {
+ for (Frame* frame = m_inspectedFrame; frame; frame = frame->tree().traverseNext(m_inspectedFrame)) {
if (frame->isLocalFrame())
toLocalFrame(frame)->document()->fetcher()->garbageCollectDocumentResources();
}
@@ -858,7 +859,7 @@ void InspectorResourceAgent::setDataSizeLimitsForTest(ErrorString*, int maxTotal
void InspectorResourceAgent::didCommitLoad(LocalFrame* frame, DocumentLoader* loader)
{
- if (loader->frame() != m_pageAgent->inspectedFrame())
+ if (loader->frame() != m_inspectedFrame)
return;
if (m_state->getBoolean(ResourceAgentState::cacheDisabled))
@@ -908,9 +909,9 @@ void InspectorResourceAgent::removeFinishedReplayXHRFired(Timer<InspectorResourc
m_replayXHRsToBeDeleted.clear();
}
-InspectorResourceAgent::InspectorResourceAgent(InspectorPageAgent* pageAgent)
+InspectorResourceAgent::InspectorResourceAgent(LocalFrame* inspectedFrame)
: InspectorBaseAgent<InspectorResourceAgent, InspectorFrontend::Network>("Network")
- , m_pageAgent(pageAgent)
+ , m_inspectedFrame(inspectedFrame)
, m_resourcesData(adoptPtr(new NetworkResourcesData()))
, m_pendingEventSource(nullptr)
, m_isRecalculatingStyle(false)

Powered by Google App Engine
This is Rietveld 408576698