Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 1092123004: DevTools: remove dependency of most agents on InspectorPageAgent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: further cuts on InspectorPageAgent inter-agents API Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 , m_agents(m_instrumentingAgents.get(), m_state.get()) 293 , m_agents(m_instrumentingAgents.get(), m_state.get())
294 , m_deferredAgentsInitialized(false) 294 , m_deferredAgentsInitialized(false)
295 { 295 {
296 ASSERT(isMainThread()); 296 ASSERT(isMainThread());
297 ASSERT(m_webLocalFrameImpl->frame()); 297 ASSERT(m_webLocalFrameImpl->frame());
298 298
299 long processId = WTF::getCurrentProcessID(); 299 long processId = WTF::getCurrentProcessID();
300 ASSERT(processId > 0); 300 ASSERT(processId > 0);
301 IdentifiersFactory::setProcessId(processId); 301 IdentifiersFactory::setProcessId(processId);
302 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ; 302 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ;
303 LocalFrame* inspectedFrame = m_webLocalFrameImpl->frame();
303 304
304 OwnPtrWillBeRawPtr<InspectorInspectorAgent> inspectorAgentPtr(InspectorInspe ctorAgent::create(injectedScriptManager)); 305 OwnPtrWillBeRawPtr<InspectorInspectorAgent> inspectorAgentPtr(InspectorInspe ctorAgent::create(injectedScriptManager));
305 m_inspectorAgent = inspectorAgentPtr.get(); 306 m_inspectorAgent = inspectorAgentPtr.get();
306 m_agents.append(inspectorAgentPtr.release()); 307 m_agents.append(inspectorAgentPtr.release());
307 308
308 OwnPtrWillBeRawPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::crea te(m_webLocalFrameImpl->frame(), m_overlay)); 309 OwnPtrWillBeRawPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::crea te(inspectedFrame, m_overlay));
309 m_pageAgent = pageAgentPtr.get(); 310 m_pageAgent = pageAgentPtr.get();
310 m_agents.append(pageAgentPtr.release()); 311 m_agents.append(pageAgentPtr.release());
311 312
312 OwnPtrWillBeRawPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create( m_pageAgent, injectedScriptManager, m_overlay)); 313 OwnPtrWillBeRawPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create( inspectedFrame, injectedScriptManager, m_overlay));
313 m_domAgent = domAgentPtr.get(); 314 m_domAgent = domAgentPtr.get();
314 m_agents.append(domAgentPtr.release()); 315 m_agents.append(domAgentPtr.release());
315 316
316 OwnPtrWillBeRawPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayer TreeAgent::create(m_pageAgent)); 317 OwnPtrWillBeRawPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayer TreeAgent::create(inspectedFrame));
317 m_layerTreeAgent = layerTreeAgentPtr.get(); 318 m_layerTreeAgent = layerTreeAgentPtr.get();
318 m_agents.append(layerTreeAgentPtr.release()); 319 m_agents.append(layerTreeAgentPtr.release());
319 320
320 m_agents.append(InspectorTimelineAgent::create()); 321 m_agents.append(InspectorTimelineAgent::create());
321 322
322 ClientMessageLoopAdapter::ensurePageScriptDebugServerCreated(m_client); 323 ClientMessageLoopAdapter::ensurePageScriptDebugServerCreated(m_client);
323 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ; 324 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ;
324 325
325 OwnPtrWillBeRawPtr<PageRuntimeAgent> pageRuntimeAgentPtr(PageRuntimeAgent::c reate(injectedScriptManager, this, scriptDebugServer, m_pageAgent)); 326 OwnPtrWillBeRawPtr<PageRuntimeAgent> pageRuntimeAgentPtr(PageRuntimeAgent::c reate(inspectedFrame, injectedScriptManager, this, scriptDebugServer));
326 m_pageRuntimeAgent = pageRuntimeAgentPtr.get(); 327 m_pageRuntimeAgent = pageRuntimeAgentPtr.get();
327 m_agents.append(pageRuntimeAgentPtr.release()); 328 m_agents.append(pageRuntimeAgentPtr.release());
328 329
329 OwnPtrWillBeRawPtr<PageConsoleAgent> pageConsoleAgentPtr = PageConsoleAgent: :create(injectedScriptManager, m_domAgent, m_pageAgent); 330 OwnPtrWillBeRawPtr<PageConsoleAgent> pageConsoleAgentPtr = PageConsoleAgent: :create(inspectedFrame, injectedScriptManager, m_domAgent);
330 m_pageConsoleAgent = pageConsoleAgentPtr.get(); 331 m_pageConsoleAgent = pageConsoleAgentPtr.get();
331 332
332 OwnPtrWillBeRawPtr<InspectorWorkerAgent> workerAgentPtr = InspectorWorkerAge nt::create(pageConsoleAgentPtr.get()); 333 OwnPtrWillBeRawPtr<InspectorWorkerAgent> workerAgentPtr = InspectorWorkerAge nt::create(pageConsoleAgentPtr.get());
333 334
334 OwnPtrWillBeRawPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracing Agent::create(this, workerAgentPtr.get(), m_pageAgent); 335 OwnPtrWillBeRawPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracing Agent::create(inspectedFrame, this, workerAgentPtr.get());
335 m_tracingAgent = tracingAgentPtr.get(); 336 m_tracingAgent = tracingAgentPtr.get();
336 m_agents.append(tracingAgentPtr.release()); 337 m_agents.append(tracingAgentPtr.release());
337 338
338 m_agents.append(workerAgentPtr.release()); 339 m_agents.append(workerAgentPtr.release());
339 m_agents.append(pageConsoleAgentPtr.release()); 340 m_agents.append(pageConsoleAgentPtr.release());
340 } 341 }
341 342
342 WebDevToolsAgentImpl::~WebDevToolsAgentImpl() 343 WebDevToolsAgentImpl::~WebDevToolsAgentImpl()
343 { 344 {
344 ASSERT(m_hasBeenDisposed); 345 ASSERT(m_hasBeenDisposed);
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 m_instrumentingAgents->reset(); 403 m_instrumentingAgents->reset();
403 } 404 }
404 405
405 void WebDevToolsAgentImpl::initializeDeferredAgents() 406 void WebDevToolsAgentImpl::initializeDeferredAgents()
406 { 407 {
407 if (m_deferredAgentsInitialized) 408 if (m_deferredAgentsInitialized)
408 return; 409 return;
409 m_deferredAgentsInitialized = true; 410 m_deferredAgentsInitialized = true;
410 411
411 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ; 412 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ;
413 LocalFrame* inspectedFrame = m_webLocalFrameImpl->frame();
412 414
413 OwnPtrWillBeRawPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourc eAgent::create(m_pageAgent)); 415 OwnPtrWillBeRawPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourc eAgent::create(inspectedFrame));
414 m_resourceAgent = resourceAgentPtr.get(); 416 m_resourceAgent = resourceAgentPtr.get();
415 m_agents.append(resourceAgentPtr.release()); 417 m_agents.append(resourceAgentPtr.release());
416 418
417 OwnPtrWillBeRawPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create( m_domAgent, m_pageAgent, m_resourceAgent)); 419 OwnPtrWillBeRawPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create( inspectedFrame, m_domAgent, m_pageAgent, m_resourceAgent));
418 m_cssAgent = cssAgentPtr.get(); 420 m_cssAgent = cssAgentPtr.get();
419 m_agents.append(cssAgentPtr.release()); 421 m_agents.append(cssAgentPtr.release());
420 422
421 m_agents.append(InspectorAnimationAgent::create(m_pageAgent, m_domAgent)); 423 m_agents.append(InspectorAnimationAgent::create(inspectedFrame, m_domAgent)) ;
422 424
423 m_agents.append(InspectorMemoryAgent::create()); 425 m_agents.append(InspectorMemoryAgent::create());
424 426
425 m_agents.append(InspectorApplicationCacheAgent::create(m_pageAgent)); 427 m_agents.append(InspectorApplicationCacheAgent::create(inspectedFrame));
426 428
427 OwnPtrWillBeRawPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgen t::create(PageScriptDebugServer::instance(), m_pageAgent, injectedScriptManager, m_overlay, m_pageRuntimeAgent->debuggerId())); 429 OwnPtrWillBeRawPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgen t::create(inspectedFrame, PageScriptDebugServer::instance(), injectedScriptManag er, m_overlay, m_pageRuntimeAgent->debuggerId()));
428 InspectorDebuggerAgent* debuggerAgent = debuggerAgentPtr.get(); 430 InspectorDebuggerAgent* debuggerAgent = debuggerAgentPtr.get();
429 m_agents.append(debuggerAgentPtr.release()); 431 m_agents.append(debuggerAgentPtr.release());
430 m_asyncCallTracker = adoptPtrWillBeNoop(new AsyncCallTracker(debuggerAgent, m_instrumentingAgents.get())); 432 m_asyncCallTracker = adoptPtrWillBeNoop(new AsyncCallTracker(debuggerAgent, m_instrumentingAgents.get()));
431 433
432 m_agents.append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent) ); 434 m_agents.append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent) );
433 435
434 m_agents.append(InspectorInputAgent::create(m_pageAgent)); 436 m_agents.append(InspectorInputAgent::create(inspectedFrame));
435 437
436 m_agents.append(InspectorProfilerAgent::create(injectedScriptManager, m_over lay)); 438 m_agents.append(InspectorProfilerAgent::create(injectedScriptManager, m_over lay));
437 439
438 m_agents.append(InspectorHeapProfilerAgent::create(injectedScriptManager)); 440 m_agents.append(InspectorHeapProfilerAgent::create(injectedScriptManager));
439 441
440 m_pageAgent->setDeferredAgents(debuggerAgent, m_cssAgent); 442 m_pageAgent->setDeferredAgents(debuggerAgent, m_cssAgent);
441 443
442 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ; 444 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ;
443 m_injectedScriptManager->injectedScriptHost()->init( 445 m_injectedScriptManager->injectedScriptHost()->init(
444 m_pageConsoleAgent.get(), 446 m_pageConsoleAgent.get(),
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 if (!InspectorBackendDispatcher::getCommandName(message, &commandName)) 716 if (!InspectorBackendDispatcher::getCommandName(message, &commandName))
715 return false; 717 return false;
716 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd) 718 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd)
717 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd) 719 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd)
718 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd) 720 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd)
719 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd) 721 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd)
720 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd); 722 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd);
721 } 723 }
722 724
723 } // namespace blink 725 } // namespace blink
OLDNEW
« Source/core/inspector/PageRuntimeAgent.h ('K') | « Source/core/inspector/PageRuntimeAgent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698