Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 1092123004: DevTools: remove dependency of most agents on InspectorPageAgent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed debug build Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/PageRuntimeAgent.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 , m_agents(m_instrumentingAgents.get(), m_state.get()) 299 , m_agents(m_instrumentingAgents.get(), m_state.get())
300 , m_deferredAgentsInitialized(false) 300 , m_deferredAgentsInitialized(false)
301 { 301 {
302 ASSERT(isMainThread()); 302 ASSERT(isMainThread());
303 ASSERT(m_webLocalFrameImpl->frame()); 303 ASSERT(m_webLocalFrameImpl->frame());
304 304
305 long processId = WTF::getCurrentProcessID(); 305 long processId = WTF::getCurrentProcessID();
306 ASSERT(processId > 0); 306 ASSERT(processId > 0);
307 IdentifiersFactory::setProcessId(processId); 307 IdentifiersFactory::setProcessId(processId);
308 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ; 308 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ;
309 LocalFrame* inspectedFrame = m_webLocalFrameImpl->frame();
309 310
310 OwnPtrWillBeRawPtr<InspectorInspectorAgent> inspectorAgentPtr(InspectorInspe ctorAgent::create(injectedScriptManager)); 311 OwnPtrWillBeRawPtr<InspectorInspectorAgent> inspectorAgentPtr(InspectorInspe ctorAgent::create(injectedScriptManager));
311 m_inspectorAgent = inspectorAgentPtr.get(); 312 m_inspectorAgent = inspectorAgentPtr.get();
312 m_agents.append(inspectorAgentPtr.release()); 313 m_agents.append(inspectorAgentPtr.release());
313 314
314 OwnPtrWillBeRawPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::crea te(m_webLocalFrameImpl->frame(), m_overlay)); 315 OwnPtrWillBeRawPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::crea te(inspectedFrame, m_overlay));
315 m_pageAgent = pageAgentPtr.get(); 316 m_pageAgent = pageAgentPtr.get();
316 m_agents.append(pageAgentPtr.release()); 317 m_agents.append(pageAgentPtr.release());
317 318
318 OwnPtrWillBeRawPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create( m_pageAgent, injectedScriptManager, m_overlay)); 319 OwnPtrWillBeRawPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create( inspectedFrame, injectedScriptManager, m_overlay));
319 m_domAgent = domAgentPtr.get(); 320 m_domAgent = domAgentPtr.get();
320 m_agents.append(domAgentPtr.release()); 321 m_agents.append(domAgentPtr.release());
321 322
322 OwnPtrWillBeRawPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayer TreeAgent::create(m_pageAgent)); 323 OwnPtrWillBeRawPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayer TreeAgent::create(inspectedFrame));
323 m_layerTreeAgent = layerTreeAgentPtr.get(); 324 m_layerTreeAgent = layerTreeAgentPtr.get();
324 m_agents.append(layerTreeAgentPtr.release()); 325 m_agents.append(layerTreeAgentPtr.release());
325 326
326 m_agents.append(InspectorTimelineAgent::create()); 327 m_agents.append(InspectorTimelineAgent::create());
327 328
328 ClientMessageLoopAdapter::ensurePageScriptDebugServerCreated(m_client); 329 ClientMessageLoopAdapter::ensurePageScriptDebugServerCreated(m_client);
329 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ; 330 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ;
330 331
331 OwnPtrWillBeRawPtr<PageRuntimeAgent> pageRuntimeAgentPtr(PageRuntimeAgent::c reate(injectedScriptManager, this, scriptDebugServer, m_pageAgent)); 332 OwnPtrWillBeRawPtr<PageRuntimeAgent> pageRuntimeAgentPtr(PageRuntimeAgent::c reate(inspectedFrame, injectedScriptManager, this, scriptDebugServer));
332 m_pageRuntimeAgent = pageRuntimeAgentPtr.get(); 333 m_pageRuntimeAgent = pageRuntimeAgentPtr.get();
333 m_agents.append(pageRuntimeAgentPtr.release()); 334 m_agents.append(pageRuntimeAgentPtr.release());
334 335
335 OwnPtrWillBeRawPtr<PageConsoleAgent> pageConsoleAgentPtr = PageConsoleAgent: :create(injectedScriptManager, m_domAgent, m_pageAgent); 336 OwnPtrWillBeRawPtr<PageConsoleAgent> pageConsoleAgentPtr = PageConsoleAgent: :create(inspectedFrame, injectedScriptManager, m_domAgent);
336 m_pageConsoleAgent = pageConsoleAgentPtr.get(); 337 m_pageConsoleAgent = pageConsoleAgentPtr.get();
337 338
338 OwnPtrWillBeRawPtr<InspectorWorkerAgent> workerAgentPtr = InspectorWorkerAge nt::create(pageConsoleAgentPtr.get()); 339 OwnPtrWillBeRawPtr<InspectorWorkerAgent> workerAgentPtr = InspectorWorkerAge nt::create(pageConsoleAgentPtr.get());
339 340
340 OwnPtrWillBeRawPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracing Agent::create(this, workerAgentPtr.get(), m_pageAgent); 341 OwnPtrWillBeRawPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracing Agent::create(inspectedFrame, this, workerAgentPtr.get());
341 m_tracingAgent = tracingAgentPtr.get(); 342 m_tracingAgent = tracingAgentPtr.get();
342 m_agents.append(tracingAgentPtr.release()); 343 m_agents.append(tracingAgentPtr.release());
343 344
344 m_agents.append(workerAgentPtr.release()); 345 m_agents.append(workerAgentPtr.release());
345 m_agents.append(pageConsoleAgentPtr.release()); 346 m_agents.append(pageConsoleAgentPtr.release());
346 } 347 }
347 348
348 WebDevToolsAgentImpl::~WebDevToolsAgentImpl() 349 WebDevToolsAgentImpl::~WebDevToolsAgentImpl()
349 { 350 {
350 ASSERT(m_hasBeenDisposed); 351 ASSERT(m_hasBeenDisposed);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 visitor->trace(m_tracingAgent); 391 visitor->trace(m_tracingAgent);
391 visitor->trace(m_pageRuntimeAgent); 392 visitor->trace(m_pageRuntimeAgent);
392 visitor->trace(m_pageConsoleAgent); 393 visitor->trace(m_pageConsoleAgent);
393 visitor->trace(m_inspectorBackendDispatcher); 394 visitor->trace(m_inspectorBackendDispatcher);
394 visitor->trace(m_agents); 395 visitor->trace(m_agents);
395 } 396 }
396 397
397 void WebDevToolsAgentImpl::willBeDestroyed() 398 void WebDevToolsAgentImpl::willBeDestroyed()
398 { 399 {
399 #if ENABLE(ASSERT) 400 #if ENABLE(ASSERT)
400 Frame* frame = m_webLocalFrameImpl->frame(); 401 LocalFrame* frame = m_webLocalFrameImpl->frame();
401 ASSERT(frame); 402 ASSERT(frame);
402 ASSERT(m_pageAgent->inspectedFrame()->view()); 403 ASSERT(frame->view());
403 #endif 404 #endif
404 405
405 detach(); 406 detach();
406 m_injectedScriptManager->disconnect(); 407 m_injectedScriptManager->disconnect();
407 m_agents.discardAgents(); 408 m_agents.discardAgents();
408 m_instrumentingAgents->reset(); 409 m_instrumentingAgents->reset();
409 } 410 }
410 411
411 void WebDevToolsAgentImpl::initializeDeferredAgents() 412 void WebDevToolsAgentImpl::initializeDeferredAgents()
412 { 413 {
413 if (m_deferredAgentsInitialized) 414 if (m_deferredAgentsInitialized)
414 return; 415 return;
415 m_deferredAgentsInitialized = true; 416 m_deferredAgentsInitialized = true;
416 417
417 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ; 418 InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get() ;
419 LocalFrame* inspectedFrame = m_webLocalFrameImpl->frame();
418 420
419 OwnPtrWillBeRawPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourc eAgent::create(m_pageAgent)); 421 OwnPtrWillBeRawPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourc eAgent::create(inspectedFrame));
420 m_resourceAgent = resourceAgentPtr.get(); 422 m_resourceAgent = resourceAgentPtr.get();
421 m_agents.append(resourceAgentPtr.release()); 423 m_agents.append(resourceAgentPtr.release());
422 424
423 OwnPtrWillBeRawPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create( m_domAgent, m_pageAgent, m_resourceAgent)); 425 OwnPtrWillBeRawPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create( inspectedFrame, m_domAgent, m_pageAgent, m_resourceAgent));
424 m_cssAgent = cssAgentPtr.get(); 426 m_cssAgent = cssAgentPtr.get();
425 m_agents.append(cssAgentPtr.release()); 427 m_agents.append(cssAgentPtr.release());
426 428
427 m_agents.append(InspectorAnimationAgent::create(m_pageAgent, m_domAgent)); 429 m_agents.append(InspectorAnimationAgent::create(inspectedFrame, m_domAgent)) ;
428 430
429 m_agents.append(InspectorMemoryAgent::create()); 431 m_agents.append(InspectorMemoryAgent::create());
430 432
431 m_agents.append(InspectorApplicationCacheAgent::create(m_pageAgent)); 433 m_agents.append(InspectorApplicationCacheAgent::create(inspectedFrame));
432 434
433 OwnPtrWillBeRawPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgen t::create(PageScriptDebugServer::instance(), m_pageAgent, injectedScriptManager, m_overlay, m_pageRuntimeAgent->debuggerId())); 435 OwnPtrWillBeRawPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgen t::create(inspectedFrame, PageScriptDebugServer::instance(), injectedScriptManag er, m_overlay, m_pageRuntimeAgent->debuggerId()));
434 InspectorDebuggerAgent* debuggerAgent = debuggerAgentPtr.get(); 436 InspectorDebuggerAgent* debuggerAgent = debuggerAgentPtr.get();
435 m_agents.append(debuggerAgentPtr.release()); 437 m_agents.append(debuggerAgentPtr.release());
436 m_asyncCallTracker = adoptPtrWillBeNoop(new AsyncCallTracker(debuggerAgent, m_instrumentingAgents.get())); 438 m_asyncCallTracker = adoptPtrWillBeNoop(new AsyncCallTracker(debuggerAgent, m_instrumentingAgents.get()));
437 439
438 m_agents.append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent) ); 440 m_agents.append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent) );
439 441
440 m_agents.append(InspectorInputAgent::create(m_pageAgent)); 442 m_agents.append(InspectorInputAgent::create(inspectedFrame));
441 443
442 m_agents.append(InspectorProfilerAgent::create(injectedScriptManager, m_over lay)); 444 m_agents.append(InspectorProfilerAgent::create(injectedScriptManager, m_over lay));
443 445
444 m_agents.append(InspectorHeapProfilerAgent::create(injectedScriptManager)); 446 m_agents.append(InspectorHeapProfilerAgent::create(injectedScriptManager));
445 447
446 m_pageAgent->setDeferredAgents(debuggerAgent, m_cssAgent); 448 m_pageAgent->setDeferredAgents(debuggerAgent, m_cssAgent);
447 449
448 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ; 450 PageScriptDebugServer* scriptDebugServer = PageScriptDebugServer::instance() ;
449 m_injectedScriptManager->injectedScriptHost()->init( 451 m_injectedScriptManager->injectedScriptHost()->init(
450 m_pageConsoleAgent.get(), 452 m_pageConsoleAgent.get(),
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 if (!InspectorBackendDispatcher::getCommandName(message, &commandName)) 722 if (!InspectorBackendDispatcher::getCommandName(message, &commandName))
721 return false; 723 return false;
722 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd) 724 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd)
723 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd) 725 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd)
724 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd) 726 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd)
725 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd) 727 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd)
726 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd); 728 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd);
727 } 729 }
728 730
729 } // namespace blink 731 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/PageRuntimeAgent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698