Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2048)

Unified Diff: runtime/observatory/tests/service/get_flag_list_rpc_test.dart

Issue 1092123003: My new tests made some bad assumptions about flag values. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_vm_rpc_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_flag_list_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_flag_list_rpc_test.dart b/runtime/observatory/tests/service/get_flag_list_rpc_test.dart
index 440d0fc8df7fb60a7ba96837233dd7f44f1c8f05..d14b2348394b1d1dd506ad9beb322c79c4d5d435 100644
--- a/runtime/observatory/tests/service/get_flag_list_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_flag_list_rpc_test.dart
@@ -27,18 +27,6 @@ var tests = [
}
expect(found, isTrue);
- // Find a modified flag.
- expect(result['modifiedFlags'].length, isPositive);
- found = false;
- for (var flag in result['modifiedFlags']) {
- if (flag['name'] == 'enable_type_checks') {
- found = true;
- expect(flag['flagType'], equals('bool'));
- expect(flag['valueAsString'], equals('true'));
- }
- }
- expect(found, isTrue);
-
// Modify a flag.
var params = {
'name' : 'code_comments',
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_vm_rpc_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698