Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1092113004: Sync the ChildNode and ParentNode interfaces with the spec (Closed)

Created:
5 years, 8 months ago by philipj_slow
Modified:
5 years, 8 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the ChildNode and ParentNode interfaces with the spec There are no changes to the generated code. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193987

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M Source/core/dom/ChildNode.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/ParentNode.idl View 1 chunk +12 lines, -6 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
5 years, 8 months ago (2015-04-17 21:51:31 UTC) #2
Jens Widell
LGTM https://codereview.chromium.org/1092113004/diff/1/Source/core/dom/ParentNode.idl File Source/core/dom/ParentNode.idl (right): https://codereview.chromium.org/1092113004/diff/1/Source/core/dom/ParentNode.idl#newcode46 Source/core/dom/ParentNode.idl:46: // [NewObject, Unscopeable] Elements queryAll(DOMString relativeSelectors); What is ...
5 years, 8 months ago (2015-04-18 07:04:25 UTC) #3
philipj_slow
https://codereview.chromium.org/1092113004/diff/1/Source/core/dom/ParentNode.idl File Source/core/dom/ParentNode.idl (right): https://codereview.chromium.org/1092113004/diff/1/Source/core/dom/ParentNode.idl#newcode46 Source/core/dom/ParentNode.idl:46: // [NewObject, Unscopeable] Elements queryAll(DOMString relativeSelectors); On 2015/04/18 07:04:25, ...
5 years, 8 months ago (2015-04-18 18:38:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092113004/1
5 years, 8 months ago (2015-04-18 18:39:49 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-18 20:06:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193987

Powered by Google App Engine
This is Rietveld 408576698