Respect declared font style on Android.

Respect declared font style on Android.

Previously the normal/italic style bit was obtained from scanning the
font file. With the new format the style may be stated explicitly, and
this explicit value in the configuration file should override any
information obtained from the font data itself.

This change allows the font element's style attribute to override the
font's style, but retains the default 'auto' setting for backwards
compatibility. Repecting the style bit may become more important with
variation fonts, because it will be up to the configuration writer to
determine what values of the 'slnt' variation should be considered
'normal' or 'italic'.

DOCS_PREVIEW= https://skia.org/?cl=1092093002

Committed: https://skia.googlesource.com/skia/+/673e902c9b9982a167f54f1cc175d8d9cab8bcaf

Committed: https://skia.googlesource.com/skia/+/e85a754a4ce9b279159270faa6717932f7a8548f

[bungeman-skia, 2015-04-17 15:39:23]

bungeman@google.com changed reviewers:
+ mtklein@google.com, tomhudson@chromium.org

[bungeman-skia, 2015-04-17 15:39:23]

We should be doing this for consistency anyway, but will be wanted when we
support variation fonts.

[bungeman-skia, 2015-04-17 18:44:45]

bungeman@google.com changed reviewers:
+ tomhudson@google.com
- tomhudson@chromium.org

[bungeman-skia, 2015-04-17 18:46:32]

Apparently I got one of the reviewers wrong earlier (sad face at autocomplete).

[bungeman-skia, 2015-04-17 18:51:34]

bungeman@google.com changed reviewers:
+ scroggo@google.com

[bungeman-skia, 2015-04-17 18:51:34]

I'll throw this out to scroggo, since he might be available.

[scroggo, 2015-04-17 19:06:50]

lgtm

https://codereview.chromium.org/1092093002/diff/20001/src/ports/SkFontConfigP...
File src/ports/SkFontConfigParser_android.h (right):

https://codereview.chromium.org/1092093002/diff/20001/src/ports/SkFontConfigP...
src/ports/SkFontConfigParser_android.h:70: enum class Style { Auto, Normal,
Italic } fStyle;
nit: Why does this not follow our enum naming conventions?

kAuto_Style etc

(Maybe "_Style" is redundant, since you can now say Style::Auto. Do we no longer
want the k for some reason I'm missing?)

[bungeman-skia, 2015-04-17 20:12:49]

https://codereview.chromium.org/1092093002/diff/20001/src/ports/SkFontConfigP...
File src/ports/SkFontConfigParser_android.h (right):

https://codereview.chromium.org/1092093002/diff/20001/src/ports/SkFontConfigP...
src/ports/SkFontConfigParser_android.h:70: enum class Style { Auto, Normal,
Italic } fStyle;
On 2015/04/17 19:06:49, scroggo wrote:
> nit: Why does this not follow our enum naming conventions?
> 
> kAuto_Style etc
> 
> (Maybe "_Style" is redundant, since you can now say Style::Auto. Do we no
longer
> want the k for some reason I'm missing?)

Done. Updated docs to have example of 'enum class' constants.

[bungeman-skia, 2015-04-17 20:18:38]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-04-17 20:18:39]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1092093002/#ps100001
(title: "remove superfluous 's'.")

[commit-bot: I haz the power, 2015-04-17 20:18:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092093002/100001

[commit-bot: I haz the power, 2015-04-17 20:25:06]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/673e902c9b9982a167f54f1cc175d8d9cab8bcaf

[jcgregorio, 2015-04-17 20:30:10]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1082173004/ by jcgregorio@google.com.

The reason for reverting is: Failed on the compile bots..

[bungeman-skia, 2015-04-17 20:38:04]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-04-17 20:38:04]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1092093002/#ps120001
(title: "Always assign style.")

[commit-bot: I haz the power, 2015-04-17 20:38:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092093002/120001

[commit-bot: I haz the power, 2015-04-17 20:51:14]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/e85a754a4ce9b279159270faa6717932f7a8548f