Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 1092073007: Oilpan: have URL object on the heap. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have URL object on the heap. Always allocate {window, worker}.URL on the Oilpan heap. R=haraken BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/dom/DOMURL.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/dom/URL.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 8 months ago (2015-04-26 16:57:33 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-27 00:58:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092073007/1
5 years, 8 months ago (2015-04-27 05:15:13 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 06:15:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194490

Powered by Google App Engine
This is Rietveld 408576698