scripts/slave/recipe_modules/chromium_tests/api.py - Issue 1092053002: Prevent analyze from filtering out crash_service target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 1092053002: Prevent analyze from filtering out crash_service target. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Fix some issues. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/api.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py

index 11e27805c5aea1bc4efbbb0548c10f8274f3a3c1..77cd63642a7a9df098993fb3c12b43c36cd19bde 100644

--- a/scripts/slave/recipe_modules/chromium_tests/api.py

+++ b/scripts/slave/recipe_modules/chromium_tests/api.py

@@ -726,6 +726,14 @@ class ChromiumTestsApi(recipe_api.RecipeApi):

# NaclIntegrationTest as it depends upon chrome not chrome_run.

compile_targets = list(set(self.m.filter.matching_exes + compile_targets))

+ # Add crash_service to compile_targets. This is done after filtering compile

+ # targets out because crash_service should always be there on windows.

+ # TODO(akuegel): Need to solve this in a better way. crbug/478053

Sergiy Byelozyorov 2015/04/17 12:44:31 s/crbug/crbug.com/

Adrian Kuegel 2015/04/17 12:47:04 Done.

+ if (self.m.platform.is_win and compile_targets and

+ 'crash_service' not in compile_targets):

+ compile_targets.extend(['crash_service'])

# Emit more detailed output useful for debugging.

analyze_details = {

'original_exes': original_exes,

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json » ('j') | no next file with comments »