Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: src/isolate.h

Issue 1092043002: Protect the emptiness of Array prototype elements with a PropertyCell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: More fixes. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.h ('k') | src/isolate.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index a434edd440c68c4b9d48d93c07a2a16aa9ec344d..d8850bcff478a964f3487e9fd245d7e314becd67 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1016,6 +1016,21 @@ class Isolate {
bool IsFastArrayConstructorPrototypeChainIntact();
+ // On intent to set an element in object, make sure that appropriate
+ // notifications occur if the set is on the elements of the array or
+ // object prototype. Also ensure that changes to prototype chain between
+ // Array and Object fire notifications.
+ void MaintainArrayProtectorOnSetElement(Handle<JSObject> object);
Jakob Kummerow 2015/04/21 15:41:49 naming nit: "Maintain" doesn't sound like somethin
mvstanton 2015/04/22 07:22:33 Good idea, I'll go with Update.
+ void MaintainArrayProtectorOnSetPrototype(Handle<JSObject> object) {
+ MaintainArrayProtectorOnSetElement(object);
+ }
+ void MaintainArrayProtectorOnNormalizeElements(Handle<JSObject> object) {
+ MaintainArrayProtectorOnSetElement(object);
+ }
+
+ // Returns true if array is the initial array prototype in any native context.
+ bool IsAnyInitialArrayPrototype(Handle<JSArray> array);
+
CallInterfaceDescriptorData* call_descriptor_data(int index);
void IterateDeferredHandles(ObjectVisitor* visitor);
« no previous file with comments | « src/hydrogen.h ('k') | src/isolate.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698