Chromium Code Reviews Chromium Code Reviews
Issue
1092033006:
[Mac/Cleanup] Trim down Foundation.h and ApplicationServices.h includes (Closed)
Description[Mac/Cleanup] Trim down Foundation.h and ApplicationServices.h includes
Foundation.h is about 100k lines of preprocessed source.
ApplicationServices is one of the many things it includes, and it is
also large (80k lines) and appears in ui/gfx/geometry headers that are
used in many places that don't care specifically about mac.
This CL avoids including Foundation.h or ApplicationServices.h from
commonly-used header files. The particular focus is on header files
typically included from other header files (versus headers most commonly
included only from .cc or .mm files).
The geometry headers get a forward-declare and fewer inline functions.
rect.h on Mac was already de-inlined, so this makes size and point
consistent with that. It also makes Mac more consistent with the
approach on Windows for native geometry types.
The main Foundation.h contributor was scoped_nsobject.h. It switches
from <Foundation/Foundation.h> (100k lines) to <Foundation/NSObject.h>
(1.5k lines). Note that even NSObject.h is not strictly needed:
<objc/objc.h> for the declaration of "nil" is sufficient, but forces
users of scoped_nsobject to make their own decision of the header to
include.
This results in a 36m20s [+/- 1s] CPU time improvement to compile times
on Mac (or a measured 1m33s [+/- 2s] real/wall time improvement on a
recent macpro). Error range gives the interval wherein lies the true
mean with a 90% confidence (6 measurements each).
There's a also a reduction in name collisions. E.g. kSmallIconSize which
is a global symbol in both Chrome and CoreServices, and is what actually
set me down this path in the first place.
BUG=None
TBR=sdefresne@chromium.org,stuartmorgan@chromium.org,thestig@chromium.org
Committed: https://crrev.com/05d4a5b475777ebbf2cbab9f76a4e2fbe40773f2
Cr-Commit-Position: refs/heads/master@{#328102}
Patch Set 1 : Attack scoped_nsobject #Patch Set 2 : Rollback non-headers #Patch Set 3 : Use a forward declare #Patch Set 4 : fix blit, cleanups, rendertext can wait #Patch Set 5 : rebase (patch conflict in permission bubble cocoa) #Patch Set 6 : fix ios, 10.6 #Patch Set 7 : fix more ios #Patch Set 8 : nit #Patch Set 9 : include -> import #Messages
Total messages: 24 (16 generated)
|
