Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart

Issue 1092023002: CPS implementation of throw and rethrow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
diff --git a/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart b/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
index 06052a966b77d58284faec0019c4913f1c3cab72..bfda4ab0365cc5095c274206062271b87e4739c2 100644
--- a/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
+++ b/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
@@ -344,18 +344,14 @@ class ASTEmitter
bodyParts.add(new VariableDeclarations(context.variables));
}
bodyParts.addAll(context.statements);
-
body = new Block(bodyParts);
-
}
- FunctionType functionType = context.currentElement.type;
-
return new ConstructorDefinition(
parameters,
body,
initializers,
- context.currentElement.name, definition.element.isConst)
- ..element = context.currentElement;
+ context.currentElement.name,
+ definition.element.isConst)..element = context.currentElement;
}
@override
@@ -564,7 +560,6 @@ class ASTEmitter
bool isFirstOccurrence = (context.variableNames[assign.variable] == null);
bool isDeclaredHere = assign.variable.host == context.currentElement;
bool isFirstStatement = context.firstStatement == statement;
- String name = context.getVariableName(assign.variable);
// Try to pull into initializer.
if (isFirstStatement && isFirstOccurrence && isDeclaredHere) {
@@ -582,8 +577,7 @@ class ASTEmitter
}
@override
- void visitReturn(tree.Return stmt,
- BuilderContext<Statement> context) {
+ void visitReturn(tree.Return stmt, BuilderContext<Statement> context) {
if (context.currentElement.isGenerativeConstructor &&
!context.inInitializer) {
assert(() {
@@ -598,8 +592,18 @@ class ASTEmitter
}
@override
- void visitBreak(tree.Break stmt,
- BuilderContext<Statement> context) {
+ void visitThrow(tree.Throw stmt, BuilderContext<Statement> context) {
+ Expression value = visitExpression(stmt.value, context);
+ context.addStatement(new ExpressionStatement(new Throw(value)));
+ }
+
+ @override
+ void visitRethrow(tree.Rethrow stmt, BuilderContext<Statement> context) {
+ context.addStatement(new Rethrow());
+ }
+
+ @override
+ void visitBreak(tree.Break stmt, BuilderContext<Statement> context) {
tree.Statement fall = context.fallthrough;
if (stmt.target.binding.next == fall) {
// Fall through to break target

Powered by Google App Engine
This is Rietveld 408576698