Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1092003002: Disable always-opt for locker tests. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable always-opt for locker tests. In no-snap mode, creating 100 contexts can take a while. This becomes even worse with always-opt. R=machenbach@chromium.org Committed: https://crrev.com/7f994ee0a738555f4e62ff1a01c7bb15472f307b Cr-Commit-Position: refs/heads/master@{#27910}

Patch Set 1 #

Patch Set 2 : fix namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/test-lockers.cc View 1 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 8 months ago (2015-04-17 08:39:38 UTC) #1
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-17 09:05:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092003002/20001
5 years, 8 months ago (2015-04-17 09:12:10 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-17 09:13:41 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 09:14:24 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f994ee0a738555f4e62ff1a01c7bb15472f307b
Cr-Commit-Position: refs/heads/master@{#27910}

Powered by Google App Engine
This is Rietveld 408576698