chrome/browser/extensions/app_sync_data_unittest.cc - Issue 10920017: [Sync] Generalize StringOrdinal to handle ordinal_in_parent field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_sync_data_unittest.cc

Issue 10920017: [Sync] Generalize StringOrdinal to handle ordinal_in_parent field (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix another compile error Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/app_sync_data_unittest.cc

diff --git a/chrome/browser/extensions/app_sync_data_unittest.cc b/chrome/browser/extensions/app_sync_data_unittest.cc

index 18f676f66af0bf134b45b35f5fe833af00a47fc1..a6d48b40be238ea82bcf3d3fb7a446378e1b94f1 100644

--- a/chrome/browser/extensions/app_sync_data_unittest.cc

+++ b/chrome/browser/extensions/app_sync_data_unittest.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/extensions/app_sync_data.h"

+#include "sync/api/string_ordinal.h"

#include "sync/protocol/app_specifics.pb.h"

#include "sync/protocol/sync.pb.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -41,9 +42,9 @@ TEST_F(AppSyncDataTest, SyncDataToExtensionSyncDataForApp) {

sync_pb::EntitySpecifics entity;

sync_pb::AppSpecifics* app_specifics = entity.mutable_app();

app_specifics->set_app_launch_ordinal(

- StringOrdinal::CreateInitialOrdinal().ToString());

+ syncer::StringOrdinal::CreateInitialOrdinal().ToString());

app_specifics->set_page_ordinal(

- StringOrdinal::CreateInitialOrdinal().ToString());

+ syncer::StringOrdinal::CreateInitialOrdinal().ToString());

sync_pb::AppNotificationSettings* notif_settings =

app_specifics->mutable_notification_settings();

notif_settings->set_oauth_client_id(kOAuthClientId);

@@ -71,9 +72,9 @@ TEST_F(AppSyncDataTest, ExtensionSyncDataToSyncDataForApp) {

sync_pb::EntitySpecifics entity;

sync_pb::AppSpecifics* input_specifics = entity.mutable_app();

input_specifics->set_app_launch_ordinal(

- StringOrdinal::CreateInitialOrdinal().ToString());

+ syncer::StringOrdinal::CreateInitialOrdinal().ToString());

input_specifics->set_page_ordinal(

- StringOrdinal::CreateInitialOrdinal().ToString());

+ syncer::StringOrdinal::CreateInitialOrdinal().ToString());

sync_pb::AppNotificationSettings* notif_settings =

input_specifics->mutable_notification_settings();

notif_settings->set_oauth_client_id(kOAuthClientId);