Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1091993002: Revert of Enforce lowercase switches when calling CommandLine::HasSwitch(const char*). (Closed)

Created:
5 years, 8 months ago by yoichio
Modified:
5 years, 8 months ago
Reviewers:
tapted, brettw, jackhou1
CC:
chromium-reviews, erikwright+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enforce lowercase switches when calling CommandLine::HasSwitch(const char*). (patchset #5 id:80001 of https://codereview.chromium.org/1046363002/) Reason for revert: This causes test fails on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27294 The test uses upper case with HasSwitch(): https://code.google.com/p/chromium/codesearch#chromium/src/content/public/android/javatests/src/org/chromium/content/browser/ContentCommandLineTest.java&q=testJavaNativeTransition&sq=package:chromium&type=cs&l=96 Original issue's description: > Enforce lowercase switches when calling CommandLine::HasSwitch. > > At the moment, all compile-time switches are lowercase. By enforcing > this, we can skip converting it to lowercase on Windows, which saves > one string allocation per call. > > On a profile with 2 extensions, HasSwitch is called ~12k times during > startup. In an ideal situation (no paging/cache pressure), the > string allocation under Windows takes ~137ns on an Xeon E5-2690 @ > 2.9Ghz. So this should shave off at least 1.6ms off a typical startup > with this hardware. For context, > Startup.BrowserMessageLoopStartTimeFromMainEntry is typically > 280-300ms on the same hardware, so we should get a ~0.5% improvement. > > BUG=472383 > > Committed: https://crrev.com/f58961749a980032241fe6c3fc829ac2e6652030 > Cr-Commit-Position: refs/heads/master@{#325576} TBR=tapted@chromium.org,brettw@chromium.org,jackhou@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472383 Committed: https://crrev.com/817cf387dbb2b63fb8c00f0f9b1535a152d88b62 Cr-Commit-Position: refs/heads/master@{#325610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M base/command_line.h View 1 chunk +1 line, -1 line 0 comments Download
M base/command_line.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/command_line_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yoichio
Created Revert of Enforce lowercase switches when calling CommandLine::HasSwitch(const char*).
5 years, 8 months ago (2015-04-17 08:27:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091993002/1
5 years, 8 months ago (2015-04-17 08:28:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 08:28:57 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 08:29:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/817cf387dbb2b63fb8c00f0f9b1535a152d88b62
Cr-Commit-Position: refs/heads/master@{#325610}

Powered by Google App Engine
This is Rietveld 408576698