Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1091983002: Correctly name header macros for src/snapshot/*.h. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly name header macros for src/snapshot/*.h. R=mvstanton@chromium.org NOTRY=true Committed: https://crrev.com/726630d29c6f89456fac781dfc02095f53ded6a2 Cr-Commit-Position: refs/heads/master@{#27933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/snapshot/natives.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/snapshot/serialize.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/snapshot/snapshot.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/snapshot/snapshot-source-sink.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yang
5 years, 8 months ago (2015-04-20 06:44:59 UTC) #1
mvstanton
lgtm -> lgtm_lgtm.
5 years, 8 months ago (2015-04-20 08:04:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091983002/1
5 years, 8 months ago (2015-04-20 08:20:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5008)
5 years, 8 months ago (2015-04-20 09:04:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091983002/1
5 years, 8 months ago (2015-04-20 09:30:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5013)
5 years, 8 months ago (2015-04-20 10:11:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091983002/1
5 years, 8 months ago (2015-04-20 10:22:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 10:22:25 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 10:22:38 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/726630d29c6f89456fac781dfc02095f53ded6a2
Cr-Commit-Position: refs/heads/master@{#27933}

Powered by Google App Engine
This is Rietveld 408576698