Use delegate object for chrome API calls in cws_widget_container

Use delegate object for chrome API calls in cws_widget_container

This would make the widget container code independent of the
chrome APIs
available/used by the extension embedding the widget.

TEST=Verified installing file handlers and file system providers works
BUG=477106
Committed: https://crrev.com/1c38f9fb2b562a62621be24ff65ea85379ef69c3
Cr-Commit-Position: refs/heads/master@{#327345}

[tbarzic, 2015-04-24 22:49:16]

tbarzic@chromium.org changed reviewers:
+ mtomasz@chromium.org

[tbarzic, 2015-04-27 18:06:06]

tbarzic@chromium.org changed reviewers:
+ yoshiki@chromium.org
- mtomasz@chromium.org

[tbarzic, 2015-04-27 18:06:06]

changing reviewer since Tomasz is ooo

[yoshiki, 2015-04-28 03:28:27]

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/app_installer.js (right):

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/app_installer.js:76: if (error) {
An empty string may come on error from the current implementation of the
delegate. Please change the implementation or check it with null strictly.

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js
(right):

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:130:
metrics: metrics,
nit: Now we have some metrics-related classes/variables, so I think the simple
name 'metrics' is confusing now. Could you rename it to more concrete name?
(but it's up to you, I don't have strong opinion here)

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:142:
chrome.runtime.lastError.message || '' : null);
I think passing empty string is not good, since both empty string and null are
treated as false. It might be better to add an prefix string, like
getInstalledItems?

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:158: return
item.extensionId;
nit: 2 space indent?

[tbarzic, 2015-04-28 04:27:43]

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/app_installer.js (right):

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/app_installer.js:76: if (error) {
On 2015/04/28 03:28:26, yoshiki wrote:
> An empty string may come on error from the current implementation of the
> delegate. Please change the implementation or check it with null strictly.

Done.

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js
(right):

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:130:
metrics: metrics,
On 2015/04/28 03:28:27, yoshiki wrote:
> nit: Now we have some metrics-related classes/variables, so I think the simple
> name 'metrics' is confusing now. Could you rename it to more concrete name?
> (but it's up to you, I don't have strong opinion here)

Done.

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:142:
chrome.runtime.lastError.message || '' : null);
On 2015/04/28 03:28:27, yoshiki wrote:
> I think passing empty string is not good, since both empty string and null are
> treated as false. It might be better to add an prefix string, like
> getInstalledItems?

Done.

https://codereview.chromium.org/1091943002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:158: return
item.extensionId;
On 2015/04/28 03:28:27, yoshiki wrote:
> nit: 2 space indent?

Done.

[yoshiki, 2015-04-28 04:52:30]

lgtm

[tbarzic, 2015-04-28 18:11:34]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2015-04-28 18:12:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091943002/80001

[commit-bot: I haz the power, 2015-04-28 19:05:29]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-28 19:06:37]

Patchset 5 (id:??) landed as
https://crrev.com/1c38f9fb2b562a62621be24ff65ea85379ef69c3
Cr-Commit-Position: refs/heads/master@{#327345}