Issue 10919298: Http Cache: Add code for simulating an infinite HTTP cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919298: Http Cache: Add code for simulating an infinite HTTP cache. (Closed)

Created:
8 years, 3 months ago by rvargas (doing something else)

Modified:
8 years, 3 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Http Cache: Add code for simulating an infinite HTTP cache. This is not completely wired yet. BUG=147383 TEST=net_unittests TBR=gavinp@chromium.org Full review http://codereview.chromium.org/10909136/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156882

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1420 lines, -5 lines)			Patch
M	net/http/http_cache.h	View		4 chunks	+7 lines, -0 lines	0 comments	Download
M	net/http/http_cache.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	net/http/http_cache_transaction.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	net/http/http_cache_transaction.cc	View		6 chunks	+27 lines, -1 line	0 comments	Download
A	net/http/infinite_cache.h	View		1 chunk	+120 lines, -0 lines	0 comments	Download
A	net/http/infinite_cache.cc	View	1 2	1 chunk	+1018 lines, -0 lines	1 comment	Download
A	net/http/infinite_cache_unittest.cc	View		1 chunk	+234 lines, -0 lines	0 comments	Download
M	net/net.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

Patch set 1 is what was reviewed before.

8 years, 3 months ago (2012-09-14 20:48:08 UTC) #1

gavinp

8 years, 3 months ago (2012-09-15 13:55:40 UTC) #2

lgtm

http://codereview.chromium.org/10919298/diff/4011/net/http/infinite_cache.cc
File net/http/infinite_cache.cc (right):

http://codereview.chromium.org/10919298/diff/4011/net/http/infinite_cache.cc#...
net/http/infinite_cache.cc:52: COMPILE_ASSERT(base::kSHA1Length ==
static_cast<unsigned>(kKeySizeBytes),
Nit: I'd be happier with implicit_cast<> here, although it requires basictypes.h

Expand Messages | Collapse Messages