Integrate map marking into static marking visitor.

Integrate map marking into static marking visitor.

This refactors the specialized marking of map contents to be done by the
static marking visitor shared between full and incremental marking. This
also fixes an issue where some maps weren't accounted for in the object
stats tracker. But more importantly, it simplifies the code base.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=12526

[Toon Verwaest, 2012-09-17 09:06:36]

lgtm with minor comments.

https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc#ne...
src/mark-compact.cc:1084: }
This method seems exactly(?) the same as the method on the incremental marker,
modulo different accessor methods (IsWhite rather than direct Getting of the
markbit; SetMark vs direct Setting; slightly inconsistent it seems). Can this be
merged?

https://chromiumcodereview.appspot.com/10919294/diff/1/src/objects-visiting-i...
File src/objects-visiting-inl.h (right):

https://chromiumcodereview.appspot.com/10919294/diff/1/src/objects-visiting-i...
src/objects-visiting-inl.h:330: // is not compacted and descriptors are
reference through a cell.
*referenced

[Michael Starzinger, 2012-09-17 09:59:36]

Addressed comments. Landing.

https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc#ne...
src/mark-compact.cc:1084: }
On 2012/09/17 09:06:36, Toon Verwaest wrote:
> This method seems exactly(?) the same as the method on the incremental marker,
> modulo different accessor methods (IsWhite rather than direct Getting of the
> markbit; SetMark vs direct Setting; slightly inconsistent it seems). Can this
be
> merged?

You are right, it does exactly the same. And I agree, there is still potential
for more code to be shared (e.g. VisitPointer[s]). But as discussed offline, we
should do that in another follow-up CL and let this one just be about the map
marking.

https://chromiumcodereview.appspot.com/10919294/diff/1/src/objects-visiting-i...
File src/objects-visiting-inl.h (right):

https://chromiumcodereview.appspot.com/10919294/diff/1/src/objects-visiting-i...
src/objects-visiting-inl.h:330: // is not compacted and descriptors are
reference through a cell.
On 2012/09/17 09:06:36, Toon Verwaest wrote:
> *referenced

Done.