Issue 10919261: Consistently use named getters for Lithium operands on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919261: Consistently use named getters for Lithium operands on ia32. (Closed)

Created:
8 years, 3 months ago by Sven Panne

Modified:
8 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Consistently use named getters for Lithium operands on ia32. With this CL we clearly distinguish two different views on Lithium instructions: For register allocation, the actual instruction/operand is irrelevant, so it has only an iterator/indexed view on the instruction operands. All other places, most importantly code generation, use named getters for the operands now, making it easy to see where each one is used. Committed: https://code.google.com/p/v8/source/detail?r=12510

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+432 lines, -253 lines)			Patch
M	src/ia32/lithium-codegen-ia32.cc	View	76 chunks	+122 lines, -126 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	102 chunks	+286 lines, -105 lines	4 comments	Download
M	src/ia32/lithium-ia32.cc	View	5 chunks	+24 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with two nits). https://chromiumcodereview.appspot.com/10919261/diff/1/src/ia32/lithium-ia32.h File src/ia32/lithium-ia32.h (right): https://chromiumcodereview.appspot.com/10919261/diff/1/src/ia32/lithium-ia32.h#newcode471 src/ia32/lithium-ia32.h:471: DECLARE_CONCRETE_INSTRUCTION(WrapReceiver, "wrap-receiver") Move this macro ...

8 years, 3 months ago (2012-09-14 09:53:25 UTC) #2

Sven Panne

8 years, 3 months ago (2012-09-14 11:53:12 UTC) #3

Landing...

https://chromiumcodereview.appspot.com/10919261/diff/1/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):

https://chromiumcodereview.appspot.com/10919261/diff/1/src/ia32/lithium-ia32....
src/ia32/lithium-ia32.h:471: DECLARE_CONCRETE_INSTRUCTION(WrapReceiver,
"wrap-receiver")
On 2012/09/14 09:53:25, Michael Starzinger wrote:
> Move this macro below the operand accessors.

Done here and at other places.

https://chromiumcodereview.appspot.com/10919261/diff/1/src/ia32/lithium-ia32....
src/ia32/lithium-ia32.h:524: DECLARE_CONCRETE_INSTRUCTION(ArgumentsLength,
"arguments-length")
On 2012/09/14 09:53:25, Michael Starzinger wrote:
> Likewise.

Done.

Expand Messages | Collapse Messages