Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1091903004: Remove 1 duplicated SVG test and rename 4 SVG text tests for selection (Closed)

Created:
5 years, 8 months ago by jaemin86.seo
Modified:
5 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, kangil_
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove 1 duplicated SVG test and rename 4 SVG text tests for selection This patch removes the following W3C-SVG-1.1 test in favor of their duplicated versions in W3C-SVG-1.1-SE and renames the following SVG text tests because they are actually testing selection. The associated expectation files have been updated as well. Remove (W3C-SVG-1.1) 1. styling-css-04-f.svg 2. styling-css-04-f-expected.png 3. styling-css-04-f-expected.txt Rename (text) 1. text-align-01-b.svg -> text-selection-align-01-b.svg 2. text-align-02-b.svg -> text-selection-align-02-b.svg 3. text-align-03-b.svg -> text-selection-align-03-b.svg 4. text-align-04-b.svg -> text-selection-align-04-b.svg 5. text-align-01-b-expected.png -> text-selection-align-01-b-expected.png 6. text-align-01-b-expected.txt -> text-selection-align-01-b-expected.txt 7. text-align-02-b-expected.png -> text-selection-align-02-b-expected.png 8. text-align-02-b-expected.txt -> text-selection-align-02-b-expected.txt 9. text-align-03-b-expected.png -> text-selection-align-03-b-expected.png 10. text-align-03-b-expected.txt -> text-selection-align-03-b-expected.txt 11. text-align-04-b-expected.png -> text-selection-align-04-b-expected.png 12. text-align-04-b-expected.txt -> text-selection-align-04-b-expected.txt BUG=477550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194436

Patch Set 1 #

Patch Set 2 : Remove 1 duplicated SVG test and rename 4 SVG text tests for reflecting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-28 lines, -1733 lines) Patch
D LayoutTests/platform/android/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/svg/text/text-align-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/svg/text/text-align-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/svg/text/text-align-04-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/svg/text/text-selection-align-02-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/svg/text/text-selection-align-03-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/svg/text/text-selection-align-04-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/styling-css-04-f-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt View 1 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-01-b-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-02-b-expected.txt View 1 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-03-b-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-04-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-align-04-b-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-02-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-02-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-03-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-03-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-04-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-align-04-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt View 1 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-01-b-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-02-b-expected.txt View 1 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-03-b-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-04-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-align-04-b-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-02-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-02-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-03-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-03-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-04-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-align-04-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-01-b-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-02-b-expected.txt View 1 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-03-b-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-04-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-align-04-b-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-02-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-02-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-03-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-03-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-04-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-align-04-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/styling-css-04-f-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt View 1 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-01-b-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-02-b-expected.txt View 1 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-03-b-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-04-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-align-04-b-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-02-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-02-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-03-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-03-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-04-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-align-04-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-01-b-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-02-b-expected.txt View 1 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-03-b-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-04-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-align-04-b-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-02-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-02-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-03-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-03-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-04-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-align-04-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/styling-css-04-f-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt View 1 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-01-b-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-02-b-expected.txt View 1 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-03-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-03-b-expected.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-04-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-align-04-b-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-02-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-02-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-03-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-03-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-04-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-align-04-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/virtual/slimmingpaint/svg/text/text-align-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win/virtual/slimmingpaint/svg/text/text-selection-align-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/svg/W3C-SVG-1.1/styling-css-04-f.svg View 1 chunk +0 lines, -134 lines 0 comments Download
D LayoutTests/svg/text/text-align-01-b.svg View 1 chunk +0 lines, -81 lines 0 comments Download
D LayoutTests/svg/text/text-align-02-b.svg View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/svg/text/text-align-03-b.svg View 1 chunk +0 lines, -75 lines 0 comments Download
D LayoutTests/svg/text/text-align-04-b.svg View 1 chunk +0 lines, -87 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-align-01-b.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-align-02-b.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-align-03-b.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-align-04-b.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
jaemin86.seo
PTAL
5 years, 8 months ago (2015-04-17 05:55:34 UTC) #2
pdr.
On 2015/04/17 at 05:55:34, jaemin86.seo wrote: > PTAL Please update this review incorporating comments from ...
5 years, 8 months ago (2015-04-18 03:33:00 UTC) #3
jaemin86.seo
PTAL :)
5 years, 8 months ago (2015-04-24 16:04:20 UTC) #26
pdr.
On 2015/04/24 at 16:04:20, jaemin86.seo wrote: > PTAL :) LGTM Another excellent change description. I ...
5 years, 8 months ago (2015-04-25 02:47:15 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091903004/430001
5 years, 8 months ago (2015-04-25 02:47:46 UTC) #29
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 16:35:21 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:430001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194436

Powered by Google App Engine
This is Rietveld 408576698