[filemanager] Improved action choices for a mounted drive.

[filemanager] Improved action choices for a mounted drive.
Also fixed blank titles.

BUG=147629
TEST=See bug.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157349

[dgozman, 2012-09-17 13:49:14]

Take a look please.

[Vladislav Kaznacheev, 2012-09-17 19:46:14]

https://chromiumcodereview.appspot.com/10918271/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/css/action_choice.css (right):

https://chromiumcodereview.appspot.com/10918271/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/css/action_choice.css:93:
url('chrome://theme/IDR_FILE_MANAGER_IMG_FILETYPE_DRIVE') no-repeat;
How about supporting HiDPI here and below?

https://chromiumcodereview.appspot.com/10918271/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/action_choice.js (right):

https://chromiumcodereview.appspot.com/10918271/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/action_choice.js:110: var extPos =
name.lastIndexOf('.');
We have a function that does this in ImageUtil. Please add a TODO for using this
function (probably after it moves to a better place)

https://chromiumcodereview.appspot.com/10918271/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/action_choice.js:122:
this.dom_.querySelector('#import-photos-to-drive').parentNode.
This branch will be executed if we have a single video and no photos. Is this
what we want?

[dgozman, 2012-09-18 11:28:08]

PTAL

https://codereview.chromium.org/10918271/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/css/action_choice.css (right):

https://codereview.chromium.org/10918271/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/css/action_choice.css:93:
url('chrome://theme/IDR_FILE_MANAGER_IMG_FILETYPE_DRIVE') no-repeat;
On 2012/09/17 19:46:14, Vladislav Kaznacheev wrote:
> How about supporting HiDPI here and below?

Done.

https://codereview.chromium.org/10918271/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/action_choice.js (right):

https://codereview.chromium.org/10918271/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/action_choice.js:110: var extPos =
name.lastIndexOf('.');
On 2012/09/17 19:46:14, Vladislav Kaznacheev wrote:
> We have a function that does this in ImageUtil. Please add a TODO for using
this
> function (probably after it moves to a better place)

Yeah, I just didn't want to include ImageUtil here. Added TODO.

https://codereview.chromium.org/10918271/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/action_choice.js:122:
this.dom_.querySelector('#import-photos-to-drive').parentNode.
On 2012/09/17 19:46:14, Vladislav Kaznacheev wrote:
> This branch will be executed if we have a single video and no photos. Is this
> what we want?

Why not? We still can backup it from the device to Drive.

[Vladislav Kaznacheev, 2012-09-18 11:41:49]

LGTM with a nit

https://chromiumcodereview.appspot.com/10918271/diff/5001/chrome/browser/reso...
File chrome/browser/resources/file_manager/css/action_choice.css (right):

https://chromiumcodereview.appspot.com/10918271/diff/5001/chrome/browser/reso...
chrome/browser/resources/file_manager/css/action_choice.css:99: background:
url(../images/icon16.png) no-repeat;
Don't we have 2x for this icon as well?

[dgozman, 2012-09-18 11:42:34]

Thank you for review.

https://codereview.chromium.org/10918271/diff/5001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/css/action_choice.css (right):

https://codereview.chromium.org/10918271/diff/5001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/css/action_choice.css:99: background:
url(../images/icon16.png) no-repeat;
On 2012/09/18 11:41:49, Vladislav Kaznacheev wrote:
> Don't we have 2x for this icon as well?

We only have 16 and 128.

[commit-bot: I haz the power, 2012-09-18 11:42:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/10918271/5001

[commit-bot: I haz the power, 2012-09-18 11:57:13]

Retried try job too often for step(s) build